Kernel Newbies archive on lore.kernel.org
 help / color / Atom feed
* checkpatch.pl CHECK alignment
@ 2019-09-02 16:17 XenoN. w0w
  2019-09-02 16:42 ` Jefferson Carpenter
  2019-09-02 18:33 ` Valdis Klētnieks
  0 siblings, 2 replies; 5+ messages in thread
From: XenoN. w0w @ 2019-09-02 16:17 UTC (permalink / raw)
  To: kernelnewbies

[-- Attachment #1.1: Type: text/plain, Size: 271 bytes --]

Hello all, I am running checkpath.pl against one driver and I’m getting
CHECK: Alignment should match open parenthesis

Are these lines worth of changing, what are the odds of that patch being accepted. I’m new and I want to contribute so sorry for dumb question

[-- Attachment #1.2: Type: text/html, Size: 1993 bytes --]

<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	margin-bottom:.0001pt;
	font-size:12.0pt;
	font-family:"Calibri",sans-serif;
	mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-family:"Calibri",sans-serif;
	mso-fareast-language:EN-US;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
	{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Hello all, I am running checkpath.pl against one driver and I’m getting<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">CHECK: Alignment should match open parenthesis<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p>&nbsp;</o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Are these lines worth of changing, what are the odds of that patch being accepted. I’m new and I want to contribute so sorry for dumb question<o:p></o:p></span></p>
</div>
</body>
</html>

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: checkpatch.pl CHECK alignment
  2019-09-02 16:17 checkpatch.pl CHECK alignment XenoN. w0w
@ 2019-09-02 16:42 ` Jefferson Carpenter
  2019-09-02 16:47   ` XenoN. w0w
  2019-09-02 18:33 ` Valdis Klētnieks
  1 sibling, 1 reply; 5+ messages in thread
From: Jefferson Carpenter @ 2019-09-02 16:42 UTC (permalink / raw)
  To: kernelnewbies

IMHO formatting reasons are not enough to submit a patch, unless the 
formatting is really whack.  If it's off by one space, it probably 
doesn't matter.  Enough lines get changed anyway without the "noise" of 
re-formatting something.  If you are touching that code anyway or 
something very near it, then you might go ahead and change the 
formatting also.

On 9/2/2019 4:17 PM, XenoN. w0w wrote:
> Hello all, I am running checkpath.pl against one driver and I’m getting
> CHECK: Alignment should match open parenthesis
> 
> Are these lines worth of changing, what are the odds of that patch being accepted. I’m new and I want to contribute so sorry for dumb question
> 
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
> 



_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: checkpatch.pl CHECK alignment
  2019-09-02 16:42 ` Jefferson Carpenter
@ 2019-09-02 16:47   ` XenoN. w0w
  0 siblings, 0 replies; 5+ messages in thread
From: XenoN. w0w @ 2019-09-02 16:47 UTC (permalink / raw)
  To: Jefferson Carpenter, kernelnewbies

Alright, thanks for answering

On 02/09/2019, 18:42, "Jefferson Carpenter" <jefferson@aoeu2code.com> wrote:

    IMHO formatting reasons are not enough to submit a patch, unless the 
    formatting is really whack.  If it's off by one space, it probably 
    doesn't matter.  Enough lines get changed anyway without the "noise" of 
    re-formatting something.  If you are touching that code anyway or 
    something very near it, then you might go ahead and change the 
    formatting also.
    
    On 9/2/2019 4:17 PM, XenoN. w0w wrote:
    > Hello all, I am running checkpath.pl against one driver and I’m getting
    > CHECK: Alignment should match open parenthesis
    > 
    > Are these lines worth of changing, what are the odds of that patch being accepted. I’m new and I want to contribute so sorry for dumb question
    > 
    > 
    > _______________________________________________
    > Kernelnewbies mailing list
    > Kernelnewbies@kernelnewbies.org
    > https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
    > 
    
    
    
    _______________________________________________
    Kernelnewbies mailing list
    Kernelnewbies@kernelnewbies.org
    https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
    

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: checkpatch.pl CHECK alignment
  2019-09-02 16:17 checkpatch.pl CHECK alignment XenoN. w0w
  2019-09-02 16:42 ` Jefferson Carpenter
@ 2019-09-02 18:33 ` Valdis Klētnieks
  2019-09-02 18:38   ` XenoN. w0w
  1 sibling, 1 reply; 5+ messages in thread
From: Valdis Klētnieks @ 2019-09-02 18:33 UTC (permalink / raw)
  To: XenoN. w0w; +Cc: kernelnewbies

[-- Warning: decoded text below may be mangled --]
[-- Attachment #1.1: Type: text/plain; charset=us-ascii, Size: 1819 bytes --]

On Mon, 02 Sep 2019 16:17:00 -0000, "XenoN. w0w" said:

> Hello all, I am running checkpath.pl against one driver and I’m getting
> CHECK: Alignment should match open parenthesis

> Are these lines worth of changing, what are the odds of that patch being
> accepted. I’m new and I want to contribute so sorry for dumb question

Digression:  If you want to contribute, you should probably first read this:
https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html

Depends where in the kernel tree it is.

If it's not under drivers/staging, a lot of maintainers won't take the patch for
several reasons:

1) Most of the kernel tree is actually pretty stable and not being worked on,
and there's always a non-zero chance of a fix-the-formatting patch being bad
and changing semantics.  It's rare but does happen.

2) Parts of the kernel are being actively worked on, and formatting patches
can introduce merge conflicts, which usually make maintainers cranky.

3) And long-term, it messes up the output of 'git blame' - rather than showing
you the commit that changed a function call from 3 parameters to 4, now it
shows the commit that moved some spaces around.  This tends to make
developers cranky.

If it *is* under drivers/staging, the patch will probably be accepted.  However, the
fact that it's under drivers/staging means there's probably several metric tons of
stuff that needs fixing, and alignment of continued lines is the least of its problems.

(Just for the record, the exfat patch *was* both sparse and checkpatch clean except
for line-too-long warnings, and look at the long list of stuff I still need to fix :)

Digression 2:
From: "XenoN. w0w" <e-net15@hotmail.com>

That's not going to get accepted on a patch - see section 11 of
Documentation/process/submitting-patches.rst

[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: checkpatch.pl CHECK alignment
  2019-09-02 18:33 ` Valdis Klētnieks
@ 2019-09-02 18:38   ` XenoN. w0w
  0 siblings, 0 replies; 5+ messages in thread
From: XenoN. w0w @ 2019-09-02 18:38 UTC (permalink / raw)
  To: Valdis Klētnieks; +Cc: kernelnewbies

[-- Attachment #1.1: Type: text/plain, Size: 2364 bytes --]

Thank you so much for your detailed response. I appreciate the effort you put in answering to me. I will follow your guidelines and tips and hopefully submit patch worth merging.
________________________________
From: Valdis Kletnieks <valdis@vt.edu> on behalf of Valdis Klçtnieks <valdis.kletnieks@vt.edu>
Sent: Monday, September 2, 2019 8:33:55 PM
To: XenoN. w0w <e-net15@hotmail.com>
Cc: kernelnewbies@kernelnewbies.org <kernelnewbies@kernelnewbies.org>
Subject: Re: checkpatch.pl CHECK alignment

On Mon, 02 Sep 2019 16:17:00 -0000, "XenoN. w0w" said:

> Hello all, I am running checkpath.pl against one driver and I’m getting
> CHECK: Alignment should match open parenthesis

> Are these lines worth of changing, what are the odds of that patch being
> accepted. I’m new and I want to contribute so sorry for dumb question

Digression:  If you want to contribute, you should probably first read this:
https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html

Depends where in the kernel tree it is.

If it's not under drivers/staging, a lot of maintainers won't take the patch for
several reasons:

1) Most of the kernel tree is actually pretty stable and not being worked on,
and there's always a non-zero chance of a fix-the-formatting patch being bad
and changing semantics.  It's rare but does happen.

2) Parts of the kernel are being actively worked on, and formatting patches
can introduce merge conflicts, which usually make maintainers cranky.

3) And long-term, it messes up the output of 'git blame' - rather than showing
you the commit that changed a function call from 3 parameters to 4, now it
shows the commit that moved some spaces around.  This tends to make
developers cranky.

If it *is* under drivers/staging, the patch will probably be accepted.  However, the
fact that it's under drivers/staging means there's probably several metric tons of
stuff that needs fixing, and alignment of continued lines is the least of its problems.

(Just for the record, the exfat patch *was* both sparse and checkpatch clean except
for line-too-long warnings, and look at the long list of stuff I still need to fix :)

Digression 2:
From: "XenoN. w0w" <e-net15@hotmail.com>

That's not going to get accepted on a patch - see section 11 of
Documentation/process/submitting-patches.rst

[-- Attachment #1.2: Type: text/html, Size: 9435 bytes --]

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=windows-1257">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<style id="x_ms-outlook-ios-style" type="text/css">
<!--
html
	{background-color:transparent!important}
body
	{background-color:transparent!important;
	color:#333;
	line-height:150%;
	font-family:"-apple-system","HelveticaNeue";
	margin:0}
.x_ms-outlook-ios-reference-expand
	{display:block;
	color:#999;
	padding:20px 0px;
	text-decoration:none}
.x_ms-outlook-ios-availability-container
	{max-width:500px;
	margin:auto;
	padding:12px 15px 15px 15px;
	border:1px solid #C7E0F4;
	border-radius:4px}
.x_ms-outlook-ios-availability-container > .x_ms-outlook-ios-availability-delete-button
	{width:25px;
	height:25px;
	right:-12px;
	top:-12px;
	background-image:url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEsAAABLCAYAAAA4TnrqAAAAAXNSR0IArs4c6QAACxpJREFUeAHlnFuMXlUVx/fcOzNtp0ynF0U7hWKrEmKLosZEjUZ9MgZIQBNC0uAtJr745oOJIT74xgskJkQbAlQNJmBMfNDEG0YjEC7GIBQZ6IAI005L79O5+/+dfut0f5dzzt7nu8w37UrWt893zt5rr/U/e6+zL+ucHrcGtLq62q9qd4gnxTeKb6kcc267eEI8Kz4mnhFPi58Rv1g5nunp6VnS8ZVHAqdHPCk+KP6zuBWEHORNinvWNWoYIN4q/o74mLidhHzqob71AxzKij8g/p14LYh6qb97QUM58T7x38TdQOiBPt0FmhQaEf9M3I2EXiNr7tOkBK3pVvGCuJsJ/dCzqVbWWxZxVTygso+InxBz3M2Efuj5SEXvUrqWQloV7lRtT4vfX6rWtS30pqr/uMZp78SqEQ2WgPqQKvmnuKWtaWnFuaWVVbciXl51rk+a9fb2uP6EY80qzL+oHB8RYC8V5vQyRIEloD6tsk965UsdAsyZ+WV35uKyOz+/4uZ0YgmEMqhfyA3397rRoV63eUOf2zzUJxAzMsed/owA+2tokWCwmgVKDcadvLDsZs8vutMXV5zkhepYl08GurENvW5idMCNj/Q5Nb5mKBiwoGoqXe/fZTQCkmNnl9x/Ty+4xZzW0yeLB9WC6Hp0QbLSJRd0sAzSGTSgzO8bG3TbN/W7IGMay/lwSJcslC+gcOZviKN9FC3pjVML7uKi+l0NDakf0Sq2DPe5kYFeh9FZBMgXJOPU3HLSOufpxzW0QTJ2bRlMZNZcCvmLD9slwHKdfraGKi2gAGhKHPXUm1tcdVMn5t05+SWfMGjbaL+7RiABUFkCuHd1I46fX6q7ERvlz/ZsHXLDA7mmNaqap+QeAQZwDSlTooDiGuOouxqWzDjJ3X91dj55slkWWs216io7musqJi5N6Zwz6uJv1XRxnqA3TAwlrTbNHHZwWNnuFmAN+30eWLeqIAO5YHr7zKK63WLqvPFDOzcNuPeODSR+KFhQZEb82/9OL7p3zi6m/k0Gq1sOuPdsjvYet6nsrxup0BAstSrmUqfEQTVxG147seCOn7vcguly+7ZtKNMdGukZdI7uf+T4xaquuW3jgLt+62CM88eILQLsQm2ldY6j0v3uV8YgoBBYC9SYxkI37RzuKFDogZ+iXuo34gaiXwRh9/0VHKqK1bUsZdqnHC9X5cr5Q9ebfveyMnS73eODOSU6c+noyYWkW1ptk9cMxnbJD6p1HbHypFUtq4LmIT9D3jHOHB9l1C1AoQ83DH2M0BN9I+hQbeuqAkuCbhB/KkQg/oGnngQm2Wn63dCifN3Rx7okeqIvegcSOIBHSilYFRQfSK8UHDCOYuIL4cz3ypl3I6EX+kHoi94R9IDfulKwJGBc/KUQQYzMbcDJ8ICnXp8vKURIh/Kg1yX9Lrln9Eb/QAIPcEnIN/FOO5mX0paYwhjhF0qMlq14R1L0q/ZfCy64MzqX4pKAVWlq94ZozqTY5nqMzBlwrgdCT5t/oj92BNK91hWtZe1SwW1FhXFRrB4YMYXJmf9atiRl7vvz52fd4/86GXNXq2TYH1oFch59blZ+yM7mp+iJvkbYkbOYYdlIwQV8HNvo0OcuJfm/9HVbZsFpMtcLpV++MOvuPvyfJPs9n9jufnrnnphRdVoNQH3jsSl36Cl29l0i466b2e0vJvRlSkTLwg7smRi9PIDNkQA+D1nL+nZOxvQSC3dGrB7oZgXTcOWJRAEMxeAIv5HUUwsUJ325SaacH/RFbyPfHjuXkR7kfK/6I03sk/zJI5o7K5xGLLPE0O03jTtalFEsYI2AQt5tkhtDvt7YE9iNPyuckpXsj4VUxnq5CiRZWbiLXY/irtL1ygCWBVSZroze6A9hD3YF0g5KMRcsJDYYjFjhLENlAGslUKazr79vl13PSCeDwWIXxoil4LIUA1g7gEJvX3/frgKbbgSsvQWZkstsVxnFdkErZ2kIYO0CCh18/X27TL+M9BbA2ppxMT0NTravx/TGBndphhIHeYCx8ukPDxDfzHCjVj30xw4Iu7x2UJvV/z/Jc3STf6bRsU2YucZ2VavIAEOejZtIn5w6qxWCubSaVgJlQrFjrjIqxT7W7QsocfCFYPn7dnZHCgQHXzbA/Kdku4FCOd8O374cxXfSDYdzMiSX/GlB8Q0oklZ/HcAevGOPdmSqVeE/5wvveb3IwjO+Hb59OQXHAatuYb62QAnBtSJy/+PMv/WrqaquRwFaGOe53mrCLxoFepZZwDpnhbLSEk02S1TdeXSudeZ+C4sd6ddVkHGC0AAjQgYC6BhgnS3K6Ds/Yg9aRY2Awne9/P39pUb6MXr5dvj25ciYAawTORmSS8wOCPuBcIa28pCcKPmTBRRTGKoqOzUKUQf9zaljV2X2U1R0GrBeKcrFdeKjjIg1aIbygLIOQdouwHz9fbsKbHoGBKr2xrIKEEhmFLmlZMWSNAQoK9AuwHz9fbus3oz0xWCwiLYziljwtyJJGgOUFWwHYL7+RBIGUtINnw3JjFCCLSDio/ymHFK+DFAmt5WAobfFd2GP3wisvox0plcFpnXxtYwM6WlcFqGJRsRHxdATWjO3KQ3lYqcwWYAhN4Z8vbHHc8V5Yv4inJbM+j/l5bRrxHAaEUhGawmlOe+hEAuU1dEIMF+u5ctK0Re9jXx77FxG+hDnqZ8Vw68p+QXHecQ47vm3LqRDh93jQ9qPu7ymnVeWmT2bFqyZs8ScVJxXIOcaRtOiAOqr+ydCW4c2K5bc0ZOXdqRZeThw7Uho8O5ueqCBtVH1E085mqNjcolIu9e9CverwsoQrKjoml5nLP2Cd6Ov040O3J06LsV3CKzVpBvqgClPUJQfUcEWO8Dgjoi79UDoaYNp9MeOQPohQJHXfBbHD/NTRDRFooKN2IeLiEyxYh1N0e9t6WmE/hFu4DEr54P1B50MGs2z4E9UMMS0gdDE5eYG9YmsdvygF/rZxBm9/Q2Lgjp/r+vp4zYFS00Nc39cUDi9TPi0TUDZ4X1FCnUjoZfFZqAvekfQd60LUiYFqyLgUaXTlePchMgUwqclLMl3WvtvhCZ2E6EPekHoib4RET9/V7FXk8KVnyqwJJBByI/8DHnHbCkRPm2E/+oWwGpjStHT3wIznXPSe/xWRb4qsCoFDyl9qnJcmBBnTvi0EYC9NLN2PgwfRf3oYYR+kfHwYFDnvxs+FDRIPaDMfHQiaJbJc7U2vJvH85UWB98QLNnOqP4+Jd/jOJTW+g0Lhgf21MNHdeQNC8ARWAymcHIf5X8osVZ01b27AzgC7Holz4nH+B9KDAKvqrfCDBgB9hUdPy4O8l9WjpRFtqvmfUMzXIB9U8cP2v+YFOcf8yYr227sTLHCwexgXb3JasAIsB/oOHgMZuUsxXha2hX/jrQZ3CxgJoe1LSLuCCSLfvteczuWuANXOK3KrDT4ZXIEZA4dsqRXuuRPdD3ah2XJ5DwAEs1C16MV0hXpksznWgSMXz0j1vZ+18FqE2A4/YfFUU9JK7/G6Zuqv9QXQxpNdwpt0YDvN8p0szhoZ6hQYOcyHFZVvDSe+5Z9W9RRCxsU3ydeEnczteQrRy0BUSgdEP+jS9Hqju9n+UgLKL6l9XXx0S4BrTu/zFYDWr/AOig+skagdf83/3zAOBZQvOryRTEf+Donbid15GuS0eOsWlBC/gsl9iW/LP6C+PPi68TN0usS8EcxH6z4be2qZrPCG5XvCFi1FQu8SZ1j6YdXYeC9YuLxiZyGicQltpuoRPiEmJVLwqPgZwXOtNKO0v8BzRAPSFNM7HEAAAAASUVORK5CYII=");
	background-size:25px 25px;
	background-position:center}
#x_ms-outlook-ios-main-container
	{margin:0 0 0 0;
	margin-top:120;
	padding:8}
#x_ms-outlook-ios-content-container
	{padding:0;
	padding-top:12;
	padding-bottom:20}
.x_ms-outlook-ios-mention
	{color:#333;
	background-color:#f1f1f1;
	border-radius:4px;
	padding:0 2px 0 2px;
	text-decoration:none}
.x_ms-outlook-ios-mention-external
	{color:#ba8f0d;
	background-color:#fdf7e7}
.x_ms-outlook-ios-mention-external-clear-design
	{color:#ba8f0d;
	background-color:#f1f1f1}
-->
</style><style id="x_ms-outlook-ios-dark-mode-style" type="text/css">
<!--
.x_ms-outlook-ios-dark-mode
	{color:#E1E1E1!important}
.x_ms-outlook-ios-dark-mode .x_ms-outlook-ios-reference-expand
	{color:#777777!important}
.x_ms-outlook-ios-dark-mode font[color="#000000"]
	{color:#E1E1E1!important}
.x_ms-outlook-ios-dark-mode .x_ms-outlook-ios-availability-container
	{border-color:#0086F0!important}
.x_ms-outlook-ios-dark-mode .x_ms-outlook-ios-availability-container .x_ms-outlook-ios-availability-timeslot-container
	{background-color:rgba(0,120,215,0.2)!important}
.x_ms-outlook-ios-dark-mode .x_ms-outlook-ios-availability-container .x_ms-outlook-ios-availability-border
	{border-top:1px solid #0086F0!important}
.x_ms-outlook-ios-dark-mode .x_ms-outlook-ios-mention
	{color:#A8A8AC!important;
	background-color:#292929!important}
-->
</style>
<div style="">
<div style="direction:ltr">
<div>Thank you so much for your detailed response. I appreciate the effort you put in answering to me. I will follow your guidelines and tips and hopefully submit patch worth merging.&nbsp;</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Valdis Kletnieks &lt;valdis@vt.edu&gt; on behalf of Valdis Klētnieks &lt;valdis.kletnieks@vt.edu&gt;<br>
<b>Sent:</b> Monday, September 2, 2019 8:33:55 PM<br>
<b>To:</b> XenoN. w0w &lt;e-net15@hotmail.com&gt;<br>
<b>Cc:</b> kernelnewbies@kernelnewbies.org &lt;kernelnewbies@kernelnewbies.org&gt;<br>
<b>Subject:</b> Re: checkpatch.pl CHECK alignment</font>
<div>&nbsp;</div>
</div>
</div>
<font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Mon, 02 Sep 2019 16:17:00 -0000, &quot;XenoN. w0w&quot; said:<br>
<br>
&gt; Hello all, I am running checkpath.pl against one driver and I’m getting<br>
&gt; CHECK: Alignment should match open parenthesis<br>
<br>
&gt; Are these lines worth of changing, what are the odds of that patch being<br>
&gt; accepted. I’m new and I want to contribute so sorry for dumb question<br>
<br>
Digression:&nbsp; If you want to contribute, you should probably first read this:<br>
<a href="https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html">https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html</a><br>
<br>
Depends where in the kernel tree it is.<br>
<br>
If it's not under drivers/staging, a lot of maintainers won't take the patch for<br>
several reasons:<br>
<br>
1) Most of the kernel tree is actually pretty stable and not being worked on,<br>
and there's always a non-zero chance of a fix-the-formatting patch being bad<br>
and changing semantics.&nbsp; It's rare but does happen.<br>
<br>
2) Parts of the kernel are being actively worked on, and formatting patches<br>
can introduce merge conflicts, which usually make maintainers cranky.<br>
<br>
3) And long-term, it messes up the output of 'git blame' - rather than showing<br>
you the commit that changed a function call from 3 parameters to 4, now it<br>
shows the commit that moved some spaces around.&nbsp; This tends to make<br>
developers cranky.<br>
<br>
If it *is* under drivers/staging, the patch will probably be accepted.&nbsp; However, the<br>
fact that it's under drivers/staging means there's probably several metric tons of<br>
stuff that needs fixing, and alignment of continued lines is the least of its problems.<br>
<br>
(Just for the record, the exfat patch *was* both sparse and checkpatch clean except<br>
for line-too-long warnings, and look at the long list of stuff I still need to fix :)<br>
<br>
Digression 2:<br>
From: &quot;XenoN. w0w&quot; &lt;e-net15@hotmail.com&gt;<br>
<br>
That's not going to get accepted on a patch - see section 11 of<br>
Documentation/process/submitting-patches.rst<br>
</div>
</span></font>
</body>
</html>

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-02 16:17 checkpatch.pl CHECK alignment XenoN. w0w
2019-09-02 16:42 ` Jefferson Carpenter
2019-09-02 16:47   ` XenoN. w0w
2019-09-02 18:33 ` Valdis Klētnieks
2019-09-02 18:38   ` XenoN. w0w

Kernel Newbies archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernelnewbies/0 kernelnewbies/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernelnewbies kernelnewbies/ https://lore.kernel.org/kernelnewbies \
		kernelnewbies@kernelnewbies.org kernelnewbies@archiver.kernel.org
	public-inbox-index kernelnewbies


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernelnewbies.kernelnewbies


AGPL code for this site: git clone https://public-inbox.org/ public-inbox