From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BDD2C3A59E for ; Mon, 2 Sep 2019 18:38:33 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB2E9216C8 for ; Mon, 2 Sep 2019 18:38:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=hotmail.com header.i=@hotmail.com header.b="kKUgcEar" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB2E9216C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=hotmail.com Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92) (envelope-from ) id 1i4rDe-0007xg-5t; Mon, 02 Sep 2019 14:38:26 -0400 Received: from mail-he1eur01olkn0829.outbound.protection.outlook.com ([2a01:111:f400:fe1e::829] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i4rDb-0007xZ-Un for kernelnewbies@kernelnewbies.org; Mon, 02 Sep 2019 14:38:24 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OskVF+yxO6ort5QAIDVR+lIKxKmuhJIxslHkw+gmcExXalcuosoNoqktTIJF52zZ9aMe4H1RlvpqTJlesoWPClbAQNW5Uzf1GSfTZx3HOGPqrNQsMB5uToqFqg1dYy0EuYLdU01U6PQEs11iib0wC1aCZ0lts8H8ESuQxDJ5B3FwDR9W43Io8Z4dpiasZyh/hY6/2kETRn5MZsWJ585HJ3A/M7O8BFrU3qoL3bPaQ508qOImDcqtuz9Z/80VBMHt0/jO4Yf5RWYRo3rYP9LX/vER+zUzRHalANYK6d3PybPRP8bN7CpDJ9ubQd8OswiO0fw7CNJ+QXU81qhOHfP7cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PM0jmKvY0to2TQ5FB5mti9tk1nnRheWmjdIeuLCgnBs=; b=MiWo02zugeit8/VwA1q4p0tQu9pwmQF9s3aiFIv0bJ53vJk2FkfhkLk/ATUUEXhTZ0kPE3MNMu1SP70giEnqpNR/u7HMKSUD9WGW7QyTkYeNN45oHx8QFogBIgtCWJuGOEVX2g9woKlKGzALvFyxP5S2vT5T+GbROkUJgBefWYBLX9yLTptdad9pnvtyyeE035aeeSrJPqJuyDhMW0qFXBsPvz5EjZn7iD5ITAD2FxmMJlnnz0z6q4jZxNmgVJHLk2jMDz5bOngkECteB+9TRH1k2fmUqvvbNc2nkuyEJIpQ1gxVT+weRbx5dYBpaqINY3oF2C+F+8gzdVpW/W/AbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PM0jmKvY0to2TQ5FB5mti9tk1nnRheWmjdIeuLCgnBs=; b=kKUgcEarbP/xElc32a5l8u43snCwNtQV2P6QEPxskhIw4oTFDXohIaWixjJntcURVs2D81cEIrlnibGlfXca/xSA1eod6uBvbyxVTmIvnyY76kGvt3rcb4GNnhRQsPlPnsFYXmV1U6S2IcbTPXB7Y5B4EMm4jZklTWVNdOHW9ROObinUD/+W8rH5L8oQJvR/aH2gKBmohfj2BahEGqqkJOsnDttO/dh1yo/1EZry78rEIPEI3rrVlFFKOt/am/oPSw3ZoHJDB8rKKg8oGG0Qg0YmPci0wA6LOwlEbpy7makNI7eoyJrc5nmqYZlha+9XHlrx+gbK3TLEkRWUrvSmrA== Received: from DB5EUR01FT056.eop-EUR01.prod.protection.outlook.com (10.152.4.59) by DB5EUR01HT073.eop-EUR01.prod.protection.outlook.com (10.152.5.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2220.16; Mon, 2 Sep 2019 18:38:21 +0000 Received: from DB7PR09MB2457.eurprd09.prod.outlook.com (10.152.4.52) by DB5EUR01FT056.mail.protection.outlook.com (10.152.5.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.16 via Frontend Transport; Mon, 2 Sep 2019 18:38:21 +0000 Received: from DB7PR09MB2457.eurprd09.prod.outlook.com ([fe80::c43b:1854:f4b9:7d88]) by DB7PR09MB2457.eurprd09.prod.outlook.com ([fe80::c43b:1854:f4b9:7d88%5]) with mapi id 15.20.2220.021; Mon, 2 Sep 2019 18:38:20 +0000 From: "XenoN. w0w" To: =?windows-1257?Q?Valdis_Kl=E7tnieks?= Subject: Re: checkpatch.pl CHECK alignment Thread-Topic: checkpatch.pl CHECK alignment Thread-Index: AQHVYanZToCSVMPwkUOWbAlLTfsmOacYtp+AgAAA8kI= Date: Mon, 2 Sep 2019 18:38:20 +0000 Message-ID: References: <072E375D-FC10-4B52-9F60-1C67C16AD7D0@hotmail.com>, <500351.1567449235@turing-police> In-Reply-To: <500351.1567449235@turing-police> Accept-Language: hr-HR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:361DF3214A56D78F507A19F471C18838386957320F23FAE63542F213DE4C572E; UpperCasedChecksum:BF677DF41F3D188BCA20F71ABBE5F1CE6308B5C23B194C58CB8922A845F9DCC0; SizeAsReceived:6749; Count:43 x-tmn: [emRE+pMqkPCIH+osd78vB/F38xdDc6It] x-ms-publictraffictype: Email x-incomingheadercount: 43 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031322404)(2017031323274)(2017031324274)(1601125500)(1603101475)(1701031045); SRVR:DB5EUR01HT073; x-ms-traffictypediagnostic: DB5EUR01HT073: x-ms-exchange-purlcount: 1 x-microsoft-antispam-message-info: eDhgO442pQTTXgif+aeLW9zSoAvxZiOmLtbqv3Pd34ekBKbBtzL+SZh3/hKUGu+C2TNJ29P9EDnBHUp+C6nZXS+KqPjYOmo45rqThAx09PHFca6rKtapvNq48zWhfko0uwfP0d2OEg8dc3jL3D2tV135BfFrkQQ2aWg85WrQe5V0EwqQhYmo7cDetw/ttns5 x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 929d92b4-b339-4364-cc01-08d72fd4bacd X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2019 18:38:20.9256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT073 Cc: "kernelnewbies@kernelnewbies.org" X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2867342238443960930==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============2867342238443960930== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DB7PR09MB24579A16130F83FEF34AD503FCBE0DB7PR09MB2457eurp_" --_000_DB7PR09MB24579A16130F83FEF34AD503FCBE0DB7PR09MB2457eurp_ Content-Type: text/plain; charset="windows-1257" Content-Transfer-Encoding: quoted-printable Thank you so much for your detailed response. I appreciate the effort you p= ut in answering to me. I will follow your guidelines and tips and hopefully= submit patch worth merging. ________________________________ From: Valdis Kletnieks on behalf of Valdis Kl=E7tnieks Sent: Monday, September 2, 2019 8:33:55 PM To: XenoN. w0w Cc: kernelnewbies@kernelnewbies.org Subject: Re: checkpatch.pl CHECK alignment On Mon, 02 Sep 2019 16:17:00 -0000, "XenoN. w0w" said: > Hello all, I am running checkpath.pl against one driver and I=92m getting > CHECK: Alignment should match open parenthesis > Are these lines worth of changing, what are the odds of that patch being > accepted. I=92m new and I want to contribute so sorry for dumb question Digression: If you want to contribute, you should probably first read this= : https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.h= tml Depends where in the kernel tree it is. If it's not under drivers/staging, a lot of maintainers won't take the patc= h for several reasons: 1) Most of the kernel tree is actually pretty stable and not being worked o= n, and there's always a non-zero chance of a fix-the-formatting patch being ba= d and changing semantics. It's rare but does happen. 2) Parts of the kernel are being actively worked on, and formatting patches can introduce merge conflicts, which usually make maintainers cranky. 3) And long-term, it messes up the output of 'git blame' - rather than show= ing you the commit that changed a function call from 3 parameters to 4, now it shows the commit that moved some spaces around. This tends to make developers cranky. If it *is* under drivers/staging, the patch will probably be accepted. How= ever, the fact that it's under drivers/staging means there's probably several metric = tons of stuff that needs fixing, and alignment of continued lines is the least of i= ts problems. (Just for the record, the exfat patch *was* both sparse and checkpatch clea= n except for line-too-long warnings, and look at the long list of stuff I still need= to fix :) Digression 2: From: "XenoN. w0w" That's not going to get accepted on a patch - see section 11 of Documentation/process/submitting-patches.rst --_000_DB7PR09MB24579A16130F83FEF34AD503FCBE0DB7PR09MB2457eurp_ Content-Type: text/html; charset="windows-1257" Content-Transfer-Encoding: quoted-printable
Thank you so much for your detailed response. I appreciate the effort = you put in answering to me. I will follow your guidelines and tips and hope= fully submit patch worth merging. 
From: Valdis Kletnieks &l= t;valdis@vt.edu> on behalf of Valdis Kl=E7tnieks <valdis.kletnieks@vt= .edu>
Sent: Monday, September 2, 2019 8:33:55 PM
To: XenoN. w0w <e-net15@hotmail.com>
Cc: kernelnewbies@kernelnewbies.org <kernelnewbies@kernelnewbies.= org>
Subject: Re: checkpatch.pl CHECK alignment
 
On Mon, 02 Sep 2019 16:17:00 -0000, "XenoN. w= 0w" said:

> Hello all, I am running checkpath.pl against one driver and I=92m gett= ing
> CHECK: Alignment should match open parenthesis

> Are these lines worth of changing, what are the odds of that patch bei= ng
> accepted. I=92m new and I want to contribute so sorry for dumb questio= n

Digression:  If you want to contribute, you should probably first read= this:
https://lists.kernelnewbies.org/pipermail/kernelnewbies/201= 7-April/017765.html

Depends where in the kernel tree it is.

If it's not under drivers/staging, a lot of maintainers won't take the patc= h for
several reasons:

1) Most of the kernel tree is actually pretty stable and not being worked o= n,
and there's always a non-zero chance of a fix-the-formatting patch being ba= d
and changing semantics.  It's rare but does happen.

2) Parts of the kernel are being actively worked on, and formatting patches=
can introduce merge conflicts, which usually make maintainers cranky.

3) And long-term, it messes up the output of 'git blame' - rather than show= ing
you the commit that changed a function call from 3 parameters to 4, now it<= br> shows the commit that moved some spaces around.  This tends to make developers cranky.

If it *is* under drivers/staging, the patch will probably be accepted. = ; However, the
fact that it's under drivers/staging means there's probably several metric = tons of
stuff that needs fixing, and alignment of continued lines is the least of i= ts problems.

(Just for the record, the exfat patch *was* both sparse and checkpatch clea= n except
for line-too-long warnings, and look at the long list of stuff I still need= to fix :)

Digression 2:
From: "XenoN. w0w" <e-net15@hotmail.com>

That's not going to get accepted on a patch - see section 11 of
Documentation/process/submitting-patches.rst
 --_000_DB7PR09MB24579A16130F83FEF34AD503FCBE0DB7PR09MB2457eurp_-- --===============2867342238443960930== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============2867342238443960930==--