From: Greg KH <gregkh@linuxfoundation.org>
To: Ian Pilcher <arequipeno@gmail.com>
Cc: axboe@kernel.dk, kernelnewbies@kernelnewbies.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
pavel@ucw.cz, linux-leds@vger.kernel.org
Subject: Re: [RFC PATCH 1/8] docs: Add block device LED trigger documentation
Date: Thu, 29 Jul 2021 07:53:17 +0200 [thread overview]
Message-ID: <YQJCTQfdBRyyz5t6@kroah.com> (raw)
In-Reply-To: <20210729015344.3366750-2-arequipeno@gmail.com>
On Wed, Jul 28, 2021 at 08:53:37PM -0500, Ian Pilcher wrote:
> * Document the sysfs attributes (/sys/class/block/led_trigger_*
> and /sys/class/block/${DEV}/led_trigger) that can be used to
> create, list, and delete block device LED triggers and to
> set and clear device/trigger associations.
sysfs apis belong in Documentation/ABI/ like all other entries.
>
> * Pull API documentation from block/blk-ledtrig.c (once it
> exists).
>
> Signed-off-by: Ian Pilcher <arequipeno@gmail.com>
> ---
> Documentation/block/index.rst | 1 +
> Documentation/block/led-triggers.rst | 124 +++++++++++++++++++++++++++
> 2 files changed, 125 insertions(+)
> create mode 100644 Documentation/block/led-triggers.rst
>
> diff --git a/Documentation/block/index.rst b/Documentation/block/index.rst
> index 86dcf7159f99..a125ecdb4c7b 100644
> --- a/Documentation/block/index.rst
> +++ b/Documentation/block/index.rst
> @@ -25,3 +25,4 @@ Block
> stat
> switching-sched
> writeback_cache_control
> + led-triggers
> diff --git a/Documentation/block/led-triggers.rst b/Documentation/block/led-triggers.rst
> new file mode 100644
> index 000000000000..a67e06c68073
> --- /dev/null
> +++ b/Documentation/block/led-triggers.rst
> @@ -0,0 +1,124 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +============
> +LED Triggers
> +============
> +
> +Available when ``CONFIG_BLK_LED_TRIGGERS=y``.
> +
> +sysfs interface
> +===============
> +
> +Create a new block device LED trigger::
> +
> + # echo foo > /sys/class/block/led_trigger_new
> +
> +The name must be unique among all LED triggers (not just block device LED
> +triggers).
> +
> +Create two more::
> +
> + # echo bar baz > /sys/class/block/led_trigger_new
> +
> +List the triggers::
> +
> + # cat /sys/class/block/led_trigger_list
> + baz: 0
> + bar: 0
> + foo: 0
As was pointed out, this is not ok for a sysfs file, sorry.
thanks,
greg k-h
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2021-07-29 6:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 1:53 [RFC PATCH 0/8] Add configurable block device LED triggers Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 1/8] docs: Add block device LED trigger documentation Ian Pilcher
2021-07-29 3:09 ` Valdis Klētnieks
2021-07-29 15:52 ` Ian Pilcher
2021-07-30 5:22 ` Greg KH
2021-07-29 5:53 ` Greg KH [this message]
2021-07-29 11:59 ` Marek Behún
2021-07-29 18:03 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 2/8] block: Add block device LED trigger list Ian Pilcher
2021-07-29 3:14 ` Valdis Klētnieks
2021-07-29 15:55 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 3/8] block: Add kernel APIs to create & delete block device LED triggers Ian Pilcher
2021-07-29 3:45 ` Valdis Klētnieks
2021-07-29 16:16 ` Ian Pilcher
2021-07-29 5:52 ` Greg KH
2021-07-29 1:53 ` [RFC PATCH 4/8] block: Add block class attributes to manage LED trigger list Ian Pilcher
2021-07-29 5:54 ` Greg KH
2021-07-29 1:53 ` [RFC PATCH 5/8] block: Add block device LED trigger info to struct genhd Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 6/8] block: Add kernel APIs to set & clear per-block device LED triggers Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 7/8] block: Add block device attributes to set & clear " Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 8/8] block: Blink device LED when request is sent to low-level driver Ian Pilcher
2021-07-29 8:54 ` [RFC PATCH 0/8] Add configurable block device LED triggers Pavel Machek
2021-07-29 17:03 ` Ian Pilcher
2021-07-29 18:35 ` Pavel Machek
2021-07-29 19:14 ` Ian Pilcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQJCTQfdBRyyz5t6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arequipeno@gmail.com \
--cc=axboe@kernel.dk \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).