From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B452C4338F for ; Thu, 29 Jul 2021 06:14:44 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C97C961042 for ; Thu, 29 Jul 2021 06:14:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C97C961042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1m8zJT-00069S-KR; Thu, 29 Jul 2021 02:14:35 -0400 Received: from mail.kernel.org ([198.145.29.99]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m8z03-0002Qj-Rs for kernelnewbies@kernelnewbies.org; Thu, 29 Jul 2021 01:54:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D67A61053; Thu, 29 Jul 2021 05:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627538068; bh=rAXscKZrW+2+4LGOnZPqFBsItZBqoTEh6dVWtmRtH2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ppnf4cw4XG1iifQPDU9vTPsziBWEDfVakd1QzjJc7424WDvwxsarkQXBOSne6lZRX 2LQTRfGte1ePbPnsuRNFBOPAGjCLDiW4aH1lspDeN3kcY1w1XQsvo64fyIaE7AJJzN hwQs8Gu2qqMdH6i2S4aDJtFdcovWFMFhZeSx/Iw0= Date: Thu, 29 Jul 2021 07:54:23 +0200 From: Greg KH To: Ian Pilcher Subject: Re: [RFC PATCH 4/8] block: Add block class attributes to manage LED trigger list Message-ID: References: <20210729015344.3366750-1-arequipeno@gmail.com> <20210729015344.3366750-5-arequipeno@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210729015344.3366750-5-arequipeno@gmail.com> Cc: axboe@kernel.dk, kernelnewbies@kernelnewbies.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, pavel@ucw.cz, linux-leds@vger.kernel.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Wed, Jul 28, 2021 at 08:53:40PM -0500, Ian Pilcher wrote: > * New class attributes - /sys/class/block/led_trigger_{new,list,del} > > * Add init function - blk_ledtrig_init() - to create the attributes > in sysfs. Call blk_ledtrig_init() from genhd_device_init() (in > block/genhd.c). > > * New file - block/blk-ledtrig.h That is an odd way to write a changelog, please read the documentation file about how to write a good changelog. thanks, greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies