From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F363AC43381 for ; Wed, 13 Mar 2019 20:40:25 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 731F4213A2 for ; Wed, 13 Mar 2019 20:40:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 731F4213A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.91) (envelope-from ) id 1h4Aet-0000B7-Of; Wed, 13 Mar 2019 16:39:27 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h3xiv-0008IL-BE for kernelnewbies@kernelnewbies.org; Wed, 13 Mar 2019 02:50:45 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0F6FED94A8F650D86FBC; Wed, 13 Mar 2019 14:50:38 +0800 (CST) Received: from [10.151.23.176] (10.151.23.176) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 13 Mar 2019 14:50:27 +0800 Subject: Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c To: References: <2d0544aa-cc99-f1dd-3b83-9f06a307dfc7@aol.com> <26452.1552459280@turing-police> From: Gao Xiang Message-ID: Date: Wed, 13 Mar 2019 14:50:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <26452.1552459280@turing-police> X-Originating-IP: [10.151.23.176] X-CFilter-Loop: Reflected X-Mailman-Approved-At: Wed, 13 Mar 2019 16:38:56 -0400 Cc: Greg Kroah-Hartman , miaoxie@huawei.com, Gao Xiang , linux-erofs@lists.ozlabs.org, kernelnewbies X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org Hi Valdis, On 2019/3/13 14:41, valdis.kletnieks@vt.edu wrote: > On Wed, 13 Mar 2019 08:48:26 +0800, Gao Xiang said: > (Reversing order of comments) >> "Release slab Memory" is not a very useful description for this function. > > Agreed. > >> i_callback is used to free inode structure and other memory related to this inode > > However, that's not a bad description at all. :) > > (Though I'd consider renaming the function to 'reap_inode_mem()' or something > like that so no description is needed. :) i_callback is an common function names for this usage, see: reiserfs/super.c 653:static void reiserfs_i_callback(struct rcu_head *head) 661: call_rcu(&inode->i_rcu, reiserfs_i_callback); romfs/super.c 384:static void romfs_i_callback(struct rcu_head *head) 393: call_rcu(&inode->i_rcu, romfs_i_callback); hfsplus/super.c 631:static void hfsplus_i_callback(struct rcu_head *head) 640: call_rcu(&inode->i_rcu, hfsplus_i_callback); qnx4/inode.c 345:static void qnx4_i_callback(struct rcu_head *head) 353: call_rcu(&inode->i_rcu, qnx4_i_callback); gfs2/super.c 1740:static void gfs2_i_callback(struct rcu_head *head) 1748: call_rcu(&inode->i_rcu, gfs2_i_callback); minix/inode.c 71:static void minix_i_callback(struct rcu_head *head) 79: call_rcu(&inode->i_rcu, minix_i_callback); jfs/super.c 127:static void jfs_i_callback(struct rcu_head *head) 147: call_rcu(&inode->i_rcu, jfs_i_callback); udf/super.c 164:static void udf_i_callback(struct rcu_head *head) 172: call_rcu(&inode->i_rcu, udf_i_callback); ufs/super.c 1452:static void ufs_i_callback(struct rcu_head *head) 1460: call_rcu(&inode->i_rcu, ufs_i_callback); openpromfs/inode.c 339:static void openprom_i_callback(struct rcu_head *head) 347: call_rcu(&inode->i_rcu, openprom_i_callback); ubifs/super.c 275:static void ubifs_i_callback(struct rcu_head *head) 287: call_rcu(&inode->i_rcu, ubifs_i_callback); Therefore fs guy should know what it does by the name convension :) Anyway, I think this patch is useful with some modification *thumb* Thanks, Gao Xiang > > > _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies