From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Mon, 03 Aug 2020 10:18:09 +0000 Subject: Re: [PATCH 13/17] watch_queue: Implement mount topology and attribute change notifications [ver #5] Message-Id: <1283475.1596449889@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <1293241.1595501326@warthog.procyon.org.uk> <158454378820.2863966.10496767254293183123.stgit@warthog.procyon.org.uk> <158454391302.2863966.1884682840541676280.stgit@warthog.procyon.org.uk> <2003787.1595585999@warthog.procyon.org.uk> <865566fb800a014868a9a7e36a00a14430efb11e.camel@themaw.net> <2023286.1595590563@warthog.procyon.org.uk> In-Reply-To: To: Miklos Szeredi Cc: dhowells@redhat.com, Ian Kent , Linus Torvalds , Al Viro , Casey Schaufler , Stephen Smalley , Nicolas Dichtel , Christian Brauner , andres@anarazel.de, Jeff Layton , dray@redhat.com, Karel Zak , keyrings@vger.kernel.org, Linux API , linux-fsdevel@vger.kernel.org, LSM , linux-kernel@vger.kernel.org Miklos Szeredi wrote: > > fsinfo() then allows you to retrieve them by path or by mount ID. > > Shouldn't the notification interface provide the unique ID? Hmmm... If I'm going to do that, I have to put the fsinfo-core branch first otherwise you can't actually retrieve the unique ID - and thus won't be able to make sense of the notification record. Such a rearrangement might make sense anyway since Ian and Karel have been primarily concentrating on fsinfo and only more recently started adding notification support. David