From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.org, viro@zeniv.linux.org.uk
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
dhowells@redhat.comdhowells@redhat.com,
casey@schaufler-ca.comsds@tycho.nsa.gov,
nicolas.dichtel@6wind.com, raven@themaw.net,
christian@brauner.io, andres@anarazel.de, jlayton@redhat.com,
dray@redhat.com, kzak@redhat.com, keyrings@vger.kernel.org,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 10/17] selinux: Implement the watch_key security hook [ver #4]
Date: Mon, 09 Mar 2020 12:18:44 +0000 [thread overview]
Message-ID: <158375632431.334846.18088471578251578185.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <158375623086.334846.16121725232323108842.stgit@warthog.procyon.org.uk>
Implement the watch_key security hook to make sure that a key grants the
caller View permission in order to set a watch on a key.
For the moment, the watch_devices security hook is left unimplemented as
it's not obvious what the object should be since the queue is global and
didn't previously exist.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
---
security/selinux/hooks.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 4b6991e178d3..95be16d3f47a 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -6563,6 +6563,17 @@ static int selinux_key_getsecurity(struct key *key, char **_buffer)
*_buffer = context;
return rc;
}
+
+#ifdef CONFIG_KEY_NOTIFICATIONS
+static int selinux_watch_key(struct key *key)
+{
+ struct key_security_struct *ksec = key->security;
+ u32 sid = current_sid();
+
+ return avc_has_perm(&selinux_state,
+ sid, ksec->sid, SECCLASS_KEY, KEY_NEED_VIEW, NULL);
+}
+#endif
#endif
#ifdef CONFIG_SECURITY_INFINIBAND
@@ -7078,6 +7089,9 @@ static struct security_hook_list selinux_hooks[] __lsm_ro_after_init = {
LSM_HOOK_INIT(key_free, selinux_key_free),
LSM_HOOK_INIT(key_permission, selinux_key_permission),
LSM_HOOK_INIT(key_getsecurity, selinux_key_getsecurity),
+#ifdef CONFIG_KEY_NOTIFICATIONS
+ LSM_HOOK_INIT(watch_key, selinux_watch_key),
+#endif
#endif
#ifdef CONFIG_AUDIT
next prev parent reply other threads:[~2020-03-09 12:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 12:17 [RFC PATCH 00/17] pipe: Keyrings, mount and superblock notifications [ver #4] David Howells
2020-03-09 12:17 ` [RFC PATCH 01/17] uapi: General notification queue definitions " David Howells
2020-03-09 12:17 ` [RFC PATCH 02/17] security: Add hooks to rule on setting a watch " David Howells
2020-03-09 12:17 ` [RFC PATCH 03/17] security: Add a hook for the point of notification insertion " David Howells
2020-03-09 12:17 ` [RFC PATCH 04/17] pipe: Add O_NOTIFICATION_PIPE " David Howells
2020-03-09 12:17 ` [RFC PATCH 05/17] pipe: Add general notification queue support " David Howells
2020-03-09 12:18 ` [RFC PATCH 06/17] watch_queue: Add a key/keyring notification facility " David Howells
2020-03-09 12:18 ` [RFC PATCH 07/17] Add sample notification program " David Howells
2020-03-09 12:18 ` [RFC PATCH 08/17] pipe: Allow buffers to be marked read-whole-or-error for notifications " David Howells
2020-03-09 12:18 ` [RFC PATCH 09/17] pipe: Add notification lossage handling " David Howells
2020-03-09 12:18 ` David Howells [this message]
2020-03-09 12:18 ` [RFC PATCH 11/17] smack: Implement the watch_key and post_notification hooks " David Howells
2020-03-09 12:19 ` [RFC PATCH 12/17] watch_queue: Add security hooks to rule on setting mount and sb watches " David Howells
2020-03-09 12:19 ` [RFC PATCH 13/17] watch_queue: Implement mount topology and attribute change notifications " David Howells
2020-03-09 12:19 ` [RFC PATCH 14/17] watch_queue: sample: Display mount tree " David Howells
2020-03-09 12:19 ` [RFC PATCH 15/17] watch_queue: Introduce a non-repeating system-unique superblock ID " David Howells
2020-03-09 12:19 ` [RFC PATCH 16/17] watch_queue: Add superblock notifications " David Howells
2020-03-09 12:19 ` [RFC PATCH 17/17] watch_queue: sample: Display " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158375632431.334846.18088471578251578185.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dhowells@redhat.comdhowells \
--cc=sds@tycho.nsa.gov \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).