Keyrings Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] certs/blacklist: fix kernel doc interface issue
@ 2020-11-06 14:38 Alex Shi
  2020-11-30 10:04 ` David Howells
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Shi @ 2020-11-06 14:38 UTC (permalink / raw)
  Cc: David Howells, David Woodhouse, keyrings, linux-kernel

certs/blacklist.c:84: warning: Function parameter or member 'hash' not
described in 'mark_hash_blacklisted'

Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: David Howells <dhowells@redhat.com> 
Cc: David Woodhouse <dwmw2@infradead.org> 
Cc: keyrings@vger.kernel.org 
Cc: linux-kernel@vger.kernel.org 
---
 certs/blacklist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/certs/blacklist.c b/certs/blacklist.c
index 6514f9ebc943..02f1016ce6e8 100644
--- a/certs/blacklist.c
+++ b/certs/blacklist.c
@@ -78,7 +78,7 @@ static void blacklist_describe(const struct key *key, struct seq_file *m)
 
 /**
  * mark_hash_blacklisted - Add a hash to the system blacklist
- * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
+ * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
  */
 int mark_hash_blacklisted(const char *hash)
 {
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] certs/blacklist: fix kernel doc interface issue
  2020-11-06 14:38 [PATCH] certs/blacklist: fix kernel doc interface issue Alex Shi
@ 2020-11-30 10:04 ` David Howells
  2020-11-30 11:14   ` Alex Shi
  0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2020-11-30 10:04 UTC (permalink / raw)
  To: Alex Shi; +Cc: dhowells, David Woodhouse, keyrings, linux-kernel

Alex Shi <alex.shi@linux.alibaba.com> wrote:

>  /**
>   * mark_hash_blacklisted - Add a hash to the system blacklist
> - * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
> + * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")

You should remove the dash when making this change.  I'll do that for you.

David


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] certs/blacklist: fix kernel doc interface issue
  2020-11-30 10:04 ` David Howells
@ 2020-11-30 11:14   ` Alex Shi
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Shi @ 2020-11-30 11:14 UTC (permalink / raw)
  To: David Howells; +Cc: David Woodhouse, keyrings, linux-kernel



在 2020/11/30 下午6:04, David Howells 写道:
> Alex Shi <alex.shi@linux.alibaba.com> wrote:
> 
>>  /**
>>   * mark_hash_blacklisted - Add a hash to the system blacklist
>> - * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
>> + * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
> 
> You should remove the dash when making this change.  I'll do that for you.


Hi David,

Very appreciate for the fixing and reminder!

Regards
Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 14:38 [PATCH] certs/blacklist: fix kernel doc interface issue Alex Shi
2020-11-30 10:04 ` David Howells
2020-11-30 11:14   ` Alex Shi

Keyrings Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/keyrings/0 keyrings/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 keyrings keyrings/ https://lore.kernel.org/keyrings \
		keyrings@vger.kernel.org
	public-inbox-index keyrings

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.keyrings


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git