From: Greg KH <greg@kroah.com>
To: keyrings@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] security/keys: remove possessor verify after key
Date: Mon, 22 Jun 2020 12:30:28 +0000 [thread overview]
Message-ID: <20200622123028.GA3502713@kroah.com> (raw)
In-Reply-To: <20200529081527.GC1376838@linux.intel.com>
On Mon, Jun 22, 2020 at 12:04:29PM +0300, Alexey Krasikov wrote:
> On 6/15/20 8:00 PM, Jarkko Sakkinen wrote:
> > On Tue, Jun 02, 2020 at 01:30:52PM +0300, Alexey Krasikov wrote:
> > > On Mon, June 1, 2020 at 08:34PM +300, Jarkko Sakkinen wrote:
> > > > On Fri, May 29, 2020 at 09:00:39AM +0300, Alexey Krasikov wrote:
> > > > > $ KEYID=$(keyctl add user john smith @u)
> > > > > $ keyctl describe $KEYID
> > > > > 5927639: alswrv-----v------------ 1000 1000 user: john
> > > > > $ keyctl setperm $KEYID 0x3d000000
> > > > > $ keyctl describe $KEYID
> > > > > 5927639: alsw-v-----v------------ 1000 1000 user: john
> > > > > $ keyctl print $KEYID
> > > > > smith
> > > > A keyring default permissions are 0x3f3f0000.
> > > > A key default permissions are 0x3f010000.
> > > >
> > > > Because of this:
> > > >
> > > > $ KEYID=$(keyctl add user john smith @u)
> > > > $ keyctl setperm $KEYID 0x3d000000
> > > > keyctl_setperm: Permission denied
> > > >
> > > > Are you sure that your example is correct?
> > > >
> > > > /Jarkko
> > > Yes, this example works correctly.
> > >
> > > Why do you think, that the current keyring and key rights
> > >
> > > shoukd not allow this to be done?
> > I'm just saying that I cannot figure out your point in the cover letter.
> > It contains random dumps of keyctl output.
> >
> > Maybe a better idea would be to write a test script that demonstrates
> > the issue?
> >
> > /Jarkko
>
> + alexey_krasikov@mail.ru
>
> Possible you may not be able to reproduce the problem because you have a
> different version of Linux.
>
> I get to reproduce the problem on two systems:
>
> Linux 4.14.74-28+yc11.91
>
> and
>
> Linux ubuntu 4.15.0-106-generic
Both of those are distro-specific kernels, can you reproduce this on
5.8-rc2 or 5.7 as released from kernel.org?
thanks,
greg k-h
next prev parent reply other threads:[~2020-06-22 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 8:15 [RFC PATCH 0/1] security/keys: remove possessor verify after key Jarkko Sakkinen
2020-06-01 17:34 ` Jarkko Sakkinen
2020-06-15 17:00 ` Jarkko Sakkinen
2020-06-22 12:30 ` Greg KH [this message]
2020-06-23 1:28 ` Jarkko Sakkinen
2020-06-28 0:27 ` Alexey Krasikov
2020-07-03 1:14 ` Jarkko Sakkinen
2020-07-13 11:53 ` Alexey Krasikov
2020-07-26 11:53 ` Alexey Krasikov
2020-09-02 17:28 ` Alexey Krasikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622123028.GA3502713@kroah.com \
--to=greg@kroah.com \
--cc=keyrings@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).