From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Date: Wed, 24 Jun 2020 00:23:35 +0000 Subject: Re: LTP: crypto: af_alg02 regression on linux-next 20200621 tag Message-Id: <20200624002335.GC12716@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20200622224920.GA4332@42.do-not-panic.com> <20200623064056.GA8121@gondor.apana.org.au> <20200623170217.GB150582@gmail.com> In-Reply-To: <20200623170217.GB150582@gmail.com> To: Eric Biggers Cc: Naresh Kamboju , Luis Chamberlain , LTP List , open list , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, lkft-triage@lists.linaro.org, linux-crypto@vger.kernel.org, Jan Stancek , chrubis , "Serge E. Hallyn" , James Morris , Jarkko Sakkinen , David Howells , "David S. Miller" On Tue, Jun 23, 2020 at 10:02:17AM -0700, Eric Biggers wrote: > > The source code for the two failing AF_ALG tests is here: > > https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/crypto/af_alg02.c > https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/crypto/af_alg05.c > > They use read() and write(), not send() and recv(). > > af_alg02 uses read() to read from a "salsa20" request socket without writing > anything to it. It is expected that this returns 0, i.e. that behaves like > encrypting an empty message. > > af_alg05 uses write() to write 15 bytes to a "cbc(aes-generic)" request socket, > then read() to read 15 bytes. It is expected that this fails with EINVAL, since > the length is not aligned to the AES block size (16 bytes). Thanks. Sounds like it's my introduction of the init variable that broke this. Let me investigate. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt