From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: keyrings@vger.kernel.org
Subject: Re: [PATCH v2] encrypted-keys: Print more useful debug info if encryption algo is not available
Date: Wed, 07 Oct 2020 03:15:08 +0000 [thread overview]
Message-ID: <20201007031508.GB143690@linux.intel.com> (raw)
In-Reply-To: <20201005225258.200181-1-anatol.pomozov@gmail.com>
On Tue, Oct 06, 2020 at 08:33:24PM -0400, Mimi Zohar wrote:
> On Wed, 2020-10-07 at 02:39 +0300, Jarkko Sakkinen wrote:
> > On Tue, Oct 06, 2020 at 10:18:43AM -0700, Anatol Pomozov wrote:
> > > Hi
> > >
> > > On Tue, Oct 6, 2020 at 8:59 AM Jarkko Sakkinen
> > > <jarkko.sakkinen@linux.intel.com> wrote:
> > > >
> > > > On Tue, Oct 06, 2020 at 06:56:28PM +0300, Jarkko Sakkinen wrote:
> > > > > On Mon, Oct 05, 2020 at 03:52:58PM -0700, Anatol Pomozov wrote:
> > > > > > It helps to improve a cryptic message "encrypted_key failed to alloc_cipher (-2)".
> > > > > > Adding algo name makes it easier to understand what cipher has failed.
> > > > > >
> > > > > > Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
> > > > >
> > > > > NAK, because you are missing David Howells from the CC list.
> > > >
> > > > Oh and also me. You are essentially missing all the keyring maintainers.
> > >
> > > The MAINTAINERS file states following:
> > >
> > > KEYS-ENCRYPTED
> > > M: Mimi Zohar <zohar@linux.ibm.com>
> > > L: linux-integrity@vger.kernel.org
> > > L: keyrings@vger.kernel.org
> > > S: Supported
> > > F: Documentation/security/keys/trusted-encrypted.rst
> > > F: include/keys/encrypted-type.h
> > > F: security/keys/encrypted-keys/
> > >
> > > Everything seems fine as I included the official maintainer and the
> > > project maillist.
> > >
> > > If David is not subscribed to the project maillist I'll be glad to CC
> > > him as well.
> >
> > Ugh, you are right then. Those two lists still confuse me thought
> > but that is not your fault.
>
> Please refer to Documentation/security/keys/trusted-encrypted.rst for
> an explanation.
Yeah, I was not sure about the organization and just spotted keyrings
in the CC list :-)
>
> >
> > Based on that I can give my ack because the change looks right
> > still.
> >
> > Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > Thanks for explaining the situation.
>
> Thanks, Jarrko. I'm on vacation, returning next week.
Have a good one!
> Mimi
/Jarkko
next prev parent reply other threads:[~2020-10-07 3:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 22:52 [PATCH v2] encrypted-keys: Print more useful debug info if encryption algo is not available Anatol Pomozov
2020-10-06 15:56 ` Jarkko Sakkinen
2020-10-06 15:56 ` Jarkko Sakkinen
2020-10-06 17:18 ` Anatol Pomozov
2020-10-06 23:39 ` Jarkko Sakkinen
2020-10-07 0:33 ` Mimi Zohar
2020-10-07 3:15 ` Jarkko Sakkinen [this message]
2020-10-12 20:18 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007031508.GB143690@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=keyrings@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).