From: joeyli <jlee@suse.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: list.lkml.keyrings@me.benboeckel.net, "Lee,
Chun-Yi" <joeyli.kernel@gmail.com>,
David Howells <dhowells@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] PKCS#7: Check codeSigning EKU for kernel module and kexec pe verification
Date: Wed, 21 Oct 2020 18:20:07 +0800 [thread overview]
Message-ID: <20201021102007.GB13854@linux-l9pv.suse> (raw)
In-Reply-To: <885f1b81-6141-a3be-1dc0-92c1fc825e3c@infradead.org>
Hi Randy,
On Tue, Oct 20, 2020 at 07:56:29AM -0700, Randy Dunlap wrote:
> On 10/20/20 6:42 AM, Ben Boeckel wrote:
> > On Tue, Oct 20, 2020 at 14:50:01 +0800, Lee, Chun-Yi wrote:
> >> +config CHECK_CODESIGN_EKU
> >> + bool "Check codeSigning extended key usage"
> >> + depends on PKCS7_MESSAGE_PARSER=y
> >> + depends on SYSTEM_DATA_VERIFICATION
> >> + help
> >> + This option provides support for checking the codeSigning extended
> >> + key usage extension when verifying the signature in PKCS#7. It
>
> extended ... extension.
> Can we drop one of those or reword it?
I will remove the _extension_ word in next version. Thanks for your review!
Joey Lee
next prev parent reply other threads:[~2020-10-21 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 6:49 [RFC PATCH 0/2] Check codeSigning extended key usage extension Lee, Chun-Yi
2020-10-20 6:50 ` [RFC PATCH 1/2] X.509: Add CodeSigning extended key usage parsing Lee, Chun-Yi
2020-10-20 6:50 ` [RFC PATCH 2/2] PKCS#7: Check codeSigning EKU for kernel module and kexec pe verification Lee, Chun-Yi
2020-10-20 13:42 ` Ben Boeckel
2020-10-20 14:56 ` Randy Dunlap
2020-10-21 10:20 ` joeyli [this message]
2020-10-21 10:10 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021102007.GB13854@linux-l9pv.suse \
--to=jlee@suse.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=joeyli.kernel@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=list.lkml.keyrings@me.benboeckel.net \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).