From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83124C388F9 for ; Wed, 21 Oct 2020 16:12:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 263212177B for ; Wed, 21 Oct 2020 16:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603296744; bh=Skv4VHOsxkbjExqgUALTljS6pv/j0ztelpvS9+0CtRw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qfnV7BiuOebcZnyo+anmaghRwOBjJiummqnxMTlh9mHp+Z3xe2Dxiy+YPFS3N4F2R oD4IgqWl2LyHy85Q40/nxm6ko4tcytUgIwzaIjS8VsZrVaRJeeVBs99CLCnmAfP9/+ QIY/uVFXe9CnjfH80joP3uI06LiNzhtaeBkBc/68= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502872AbgJUQMX (ORCPT ); Wed, 21 Oct 2020 12:12:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:56946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502871AbgJUQMX (ORCPT ); Wed, 21 Oct 2020 12:12:23 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 77C932087D; Wed, 21 Oct 2020 16:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603296742; bh=Skv4VHOsxkbjExqgUALTljS6pv/j0ztelpvS9+0CtRw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SY2cnni/yKiqNX2D+MolwtBJkJZ25el2hwQIqa11SFtDmBTq22ksfzgjhnYpbguzD uBJI7QL3KluS3eIdXrPW4GsEYXfXh8wZGwW2M5LAz2S2HyPezXFwhGB9FXwsuwf6Qg XKD6E/hfwsCovIhfz5qaKfu2Q5NHx6cNpzquq6Po= Date: Wed, 21 Oct 2020 18:13:01 +0200 From: Greg KH To: Christoph Hellwig , kernel-team@android.com Cc: Alexander Viro , Andrew Morton , Jens Axboe , Arnd Bergmann , David Howells , David Laight , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c" Message-ID: <20201021161301.GA1196312@kroah.com> References: <20200925045146.1283714-1-hch@lst.de> <20200925045146.1283714-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925045146.1283714-3-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > From: David Laight > > This lets the compiler inline it into import_iovec() generating > much better code. > > Signed-off-by: David Laight > Signed-off-by: Christoph Hellwig > --- > fs/read_write.c | 179 ------------------------------------------------ > lib/iov_iter.c | 176 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 176 insertions(+), 179 deletions(-) Strangely, this commit causes a regression in Linus's tree right now. I can't really figure out what the regression is, only that this commit triggers a "large Android system binary" from working properly. There's no kernel log messages anywhere, and I don't have any way to strace the thing in the testing framework, so any hints that people can provide would be most appreciated. thanks, greg k-h