keyrings.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Snowberg <eric.snowberg@oracle.com>
To: dhowells@redhat.com, dwmw2@infradead.org
Cc: keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
	eric.snowberg@oracle.com
Subject: [PATCH] cert: Add kconfig dependency for validate_trust
Date: Wed, 17 Feb 2021 11:50:58 -0500	[thread overview]
Message-ID: <20210217165058.1336155-1-eric.snowberg@oracle.com> (raw)

The kernel test robot reports when building with Kconfig
CONFIG_INTEGRITY_PLATFORM_KEYRING defined and 
CONFIG_SYSTEM_DATA_VERIFICATION undefined:

ld.lld: error: undefined symbol: pkcs7_validate_trust
referenced by blacklist.c:128 (certs/blacklist.c:128)
             blacklist.o:(is_key_on_revocation_list) in archive certs/built-in.a

Make CONFIG_SYSTEM_DATA_VERIFICATION a dependency for validate_trust.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
---
 certs/blacklist.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/certs/blacklist.h b/certs/blacklist.h
index 420bb7c86e07..a86f0b52a033 100644
--- a/certs/blacklist.h
+++ b/certs/blacklist.h
@@ -4,7 +4,7 @@
 
 extern const char __initconst *const blacklist_hashes[];
 
-#ifdef CONFIG_INTEGRITY_PLATFORM_KEYRING
+#if defined(CONFIG_INTEGRITY_PLATFORM_KEYRING) && defined(SYSTEM_DATA_VERIFICATION)
 #define validate_trust pkcs7_validate_trust
 #else
 static inline int validate_trust(struct pkcs7_message *pkcs7,
-- 
2.18.4


             reply	other threads:[~2021-02-17 16:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 16:50 Eric Snowberg [this message]
2021-02-23 23:47 ` [PATCH] cert: Add kconfig dependency for validate_trust David Howells
2021-02-24  1:26   ` Eric Snowberg
2021-02-24 10:51   ` David Howells
2021-02-24 11:56     ` Mickaël Salaün
2021-02-24 12:40     ` David Howells
2021-02-25  4:03     ` Eric Snowberg
2021-02-25 14:43     ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210217165058.1336155-1-eric.snowberg@oracle.com \
    --to=eric.snowberg@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).