keyrings.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] KEYS: trusted: tee: fix build error due to missing include
@ 2021-03-17 14:29 Ahmad Fatoum
  2021-03-17 21:57 ` Jarkko Sakkinen
  0 siblings, 1 reply; 3+ messages in thread
From: Ahmad Fatoum @ 2021-03-17 14:29 UTC (permalink / raw)
  To: Sumit Garg, James Bottomley, Jarkko Sakkinen, Mimi Zohar, David Howells
  Cc: kernel, Ahmad Fatoum, James Morris, Serge E. Hallyn,
	linux-integrity, keyrings, linux-security-module, linux-kernel

MODULE_DEVICE_TABLE is defined in <linux/module.h>, which is not
included. Add the include to fix the build error its lack caused.

Cc: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 security/keys/trusted-keys/trusted_tee.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/keys/trusted-keys/trusted_tee.c b/security/keys/trusted-keys/trusted_tee.c
index 62983d98a252..2ce66c199e1d 100644
--- a/security/keys/trusted-keys/trusted_tee.c
+++ b/security/keys/trusted-keys/trusted_tee.c
@@ -8,6 +8,7 @@
 
 #include <linux/err.h>
 #include <linux/key-type.h>
+#include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/tee_drv.h>
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] KEYS: trusted: tee: fix build error due to missing include
  2021-03-17 14:29 [PATCH] KEYS: trusted: tee: fix build error due to missing include Ahmad Fatoum
@ 2021-03-17 21:57 ` Jarkko Sakkinen
  2021-03-18  7:06   ` Ahmad Fatoum
  0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Sakkinen @ 2021-03-17 21:57 UTC (permalink / raw)
  To: Ahmad Fatoum
  Cc: Sumit Garg, James Bottomley, Mimi Zohar, David Howells, kernel,
	James Morris, Serge E. Hallyn, linux-integrity, keyrings,
	linux-security-module, linux-kernel

On Wed, Mar 17, 2021 at 03:29:05PM +0100, Ahmad Fatoum wrote:
> MODULE_DEVICE_TABLE is defined in <linux/module.h>, which is not
> included. Add the include to fix the build error its lack caused.
> 
> Cc: Sumit Garg <sumit.garg@linaro.org>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Hi, I appreciate your work, thanks for taking action, but unfortunately
I already incorporated this fix to the original patch.

/Jarkko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] KEYS: trusted: tee: fix build error due to missing include
  2021-03-17 21:57 ` Jarkko Sakkinen
@ 2021-03-18  7:06   ` Ahmad Fatoum
  0 siblings, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2021-03-18  7:06 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: Sumit Garg, James Bottomley, Mimi Zohar, David Howells, kernel,
	James Morris, Serge E. Hallyn, linux-integrity, keyrings,
	linux-security-module, linux-kernel

Hi Jarkko,

On 17.03.21 22:57, Jarkko Sakkinen wrote:
> On Wed, Mar 17, 2021 at 03:29:05PM +0100, Ahmad Fatoum wrote:
>> MODULE_DEVICE_TABLE is defined in <linux/module.h>, which is not
>> included. Add the include to fix the build error its lack caused.
>>
>> Cc: Sumit Garg <sumit.garg@linaro.org>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> 
> Hi, I appreciate your work, thanks for taking action, but unfortunately
> I already incorporated this fix to the original patch.

Nothing unfortunate about this! :)

Cheers,
Ahmad

> 
> /Jarkko
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-18  7:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 14:29 [PATCH] KEYS: trusted: tee: fix build error due to missing include Ahmad Fatoum
2021-03-17 21:57 ` Jarkko Sakkinen
2021-03-18  7:06   ` Ahmad Fatoum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).