From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B414FC8300F for ; Mon, 23 Nov 2020 00:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DE2F20936 for ; Mon, 23 Nov 2020 00:54:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726131AbgKWAyH (ORCPT ); Sun, 22 Nov 2020 19:54:07 -0500 Received: from smtprelay0002.hostedemail.com ([216.40.44.2]:50256 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725782AbgKWAyH (ORCPT ); Sun, 22 Nov 2020 19:54:07 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 2D37318029125; Mon, 23 Nov 2020 00:54:05 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: steam95_4513bd127361 X-Filterd-Recvd-Size: 3177 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Mon, 23 Nov 2020 00:53:59 +0000 (UTC) Message-ID: <21826b6d513c4d9ccc795179c1edb0df2361d870.camel@perches.com> Subject: Re: [RFC] MAINTAINERS tag for cleanup robot From: Joe Perches To: Finn Thain Cc: James Bottomley , Tom Rix , Matthew Wilcox , clang-built-linux@googlegroups.com, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, tboot-devel@lists.sourceforge.net, kvm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, netdev@vger.kernel.org, linux-media@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, keyrings@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, alsa-devel@alsa-project.org, bpf@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-nfs@vger.kernel.org, patches@opensource.cirrus.com Date: Sun, 22 Nov 2020 16:53:58 -0800 In-Reply-To: References: <20201121165058.1644182-1-trix@redhat.com> <20201122032304.GE4327@casper.infradead.org> <20201122145635.GG4327@casper.infradead.org> <0819ce06-c462-d4df-d3d9-14931dc5aefc@redhat.com> <751803306cd957d0e7ef6a4fc3dbf12ebceaba92.camel@HansenPartnership.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org On Mon, 2020-11-23 at 09:33 +1100, Finn Thain wrote: > On Sun, 22 Nov 2020, Joe Perches wrote: > > But provably correct conversions IMO _should_ be done and IMO churn > > considerations should generally have less importance. [] > Moreover, the patch review workload for skilled humans is being generated > by the automation, which is completely backwards: the machine is supposed > to be helping. Which is why the provably correct matters. coccinelle transforms can be, but are not necessarily, provably correct. The _show transforms done via the sysfs_emit_dev.cocci script are correct as in commit aa838896d87a ("drivers core: Use sysfs_emit and sysfs_emit_at for show(device *...) functions") Worthwhile? A different question, but I think yes as it reduces the overall question space of the existing other sprintf overrun possibilities.