From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Wed, 22 Jul 2020 20:02:27 +0000 Subject: Re: [PATCH v2] KEYS: remove redundant memset Message-Id: <2bdd6b8ec731d180023d593b679afc66def19b4f.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20200722134610.31947-1-trix@redhat.com> In-Reply-To: <20200722134610.31947-1-trix@redhat.com> To: trix@redhat.com, dhowells@redhat.com, jarkko.sakkinen@linux.intel.com, jmorris@namei.org, serge@hallyn.com, denkenz@gmail.com, marcel@holtmann.org Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 2020-07-22 at 06:46 -0700, trix@redhat.com wrote: > From: Tom Rix > > Reviewing use of memset in keyctrl_pkey.c > > keyctl_pkey_params_get prologue code to set params up > > memset(params, 0, sizeof(*params)); > params->encoding = "raw"; > > keyctl_pkey_query has the same prologue > and calls keyctl_pkey_params_get. > > So remove the prologue. > > Fixes: 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]") At best, this is a micro optimization. How is this appropriate for a Fixes: line? > diff --git a/security/keys/keyctl_pkey.c b/security/keys/keyctl_pkey.c [] > @@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id, > struct kernel_pkey_query res; > long ret; > > - memset(¶ms, 0, sizeof(params)); > - > ret = keyctl_pkey_params_get(id, _info, ¶ms); > if (ret < 0) > goto error;