From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392D0C636D6 for ; Fri, 17 Feb 2023 20:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbjBQUiE (ORCPT ); Fri, 17 Feb 2023 15:38:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjBQUiE (ORCPT ); Fri, 17 Feb 2023 15:38:04 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 239AC60F9E for ; Fri, 17 Feb 2023 12:37:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676666234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=119wxXgezxpOHxSCYpEJOooTZ3WjAfPGcRTU8gk3U5w=; b=d86J21ES7p1SU2QCU2BOnyVKS2wbCRyqFmU96fitTR1I1PJsdYEcvsEMzhyszDiE1kX60k zSarOT1WIyXe6JlARvl0+MsQ8d5A1Us/gFrKpg1CvudjM8Zrkw66rVw9lCa46kF1OHqgyY 3HIBnBkB0e2LQA55PgXuzMioUqWzrBY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-583-JyIrDOtpMwqtLzA6LL-r0A-1; Fri, 17 Feb 2023 15:37:08 -0500 X-MC-Unique: JyIrDOtpMwqtLzA6LL-r0A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BC7BD382C97B for ; Fri, 17 Feb 2023 20:37:07 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5BC672166B30; Fri, 17 Feb 2023 20:37:07 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230217201435.39784-3-rharwood@redhat.com> References: <20230217201435.39784-3-rharwood@redhat.com> <20230217201435.39784-1-rharwood@redhat.com> To: Robbie Harwood Cc: dhowells@redhat.com, keyrings@vger.kernel.org Subject: Re: [PATCH v1 2/2] asymmetric_keys: log on fatal failures in PE/pkcs7 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <519728.1676666226.1@warthog.procyon.org.uk> Date: Fri, 17 Feb 2023 20:37:06 +0000 Message-ID: <519730.1676666226@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org Robbie Harwood wrote: > These particular errors can be encountered while trying to kexec when > secureboot lockdown is in place. Without this change, even with a > signed debug build, one still needs to reboot the machine to add the > appropriate dyndbg parameters (since lockdown blocks debugfs). > > Accordingly, upgrade all pr_debug() before fatal error into pr_info(). I wonder if they should then be pr_warn() instead. > Signed-off-by: Robbie Harwood Acked-by: David Howells