From: Jarkko Sakkinen <jarkko@kernel.org>
To: zhenwei pi <pizhenwei@bytedance.com>,
dhowells@redhat.com, herbert@gondor.apana.org.au,
davem@davemloft.net
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Re: PING: [PATCH] crypto: public_key: fix overflow during implicit conversion
Date: Thu, 19 Aug 2021 13:35:52 +0300 [thread overview]
Message-ID: <6db55147350d81ed205d37031d81b03b80f639cc.camel@kernel.org> (raw)
In-Reply-To: <8bf3a04d-f1a7-cd8c-5c5a-ace3de500b2f@bytedance.com>
On Thu, 2021-08-19 at 10:03 +0800, zhenwei pi wrote:
> On 8/18/21 8:33 PM, Jarkko Sakkinen wrote:
> > On Wed, 2021-08-18 at 16:33 +0800, zhenwei pi wrote:
> > > PING
> >
> > Please, do not top-post.
> >
> > You are lacking Herbert Xu:
> >
> > $ scripts/get_maintainer.pl crypto/asymmetric_keys/public_key.c
> > David Howells <dhowells@redhat.com> (maintainer:ASYMMETRIC KEYS)
> > Herbert Xu <herbert@gondor.apana.org.au> (maintainer:CRYPTO API)
> > "David S. Miller" <davem@davemloft.net> (maintainer:CRYPTO API)
> > keyrings@vger.kernel.org (open list:ASYMMETRIC KEYS)
> > linux-crypto@vger.kernel.org (open list:CRYPTO API)
> > linux-kernel@vger.kernel.org (open list)
> >
> > > On 8/10/21 2:39 PM, zhenwei pi wrote:
> > > > Hit kernel warning like this, it can be reproduced by verifying
> > > > 256
> > > > bytes datafile by keyctl command.
> > > >
> > > > WARNING: CPU: 5 PID: 344556 at crypto/rsa-pkcs1pad.c:540
> > > > pkcs1pad_verify+0x160/0x190
> > > > ...
> > > > Call Trace:
> > > > public_key_verify_signature+0x282/0x380
> > > > ? software_key_query+0x12d/0x180
> > > > ? keyctl_pkey_params_get+0xd6/0x130
> > > > asymmetric_key_verify_signature+0x66/0x80
> > > > keyctl_pkey_verify+0xa5/0x100
> > > > do_syscall_64+0x35/0xb0
> > > > entry_SYSCALL_64_after_hwframe+0x44/0xae
> > > >
> > > > '.digest_size(u8) = params->in_len(u32)' leads overflow of an
> > > > u8
> >
> > Where is this statement?
> >
>
> In function "static int asymmetric_key_verify_signature(struct
> kernel_pkey_params *params, const void *in, const void *in2)"
>
> > > > value,
> > > > so use u32 instead of u8 of digest. And reorder struct
> > > > public_key_signature, it could save 8 bytes on a 64 bit
> > > > machine.
> > ~~~~~
> > 64-bit
> >
> > What do you mean by "could"? Does it, or does it
> > not?
> >
> >
> >
> After reordering struct public_key_signature, sizeof(struct
> public_key_signature) gets smaller than the original version.
OK, then just state is as "it saves" instead of "it could save".
Not a requirement but have you been able to trigger this for a
kernel that does not have this fix?
/Jarkko
next prev parent reply other threads:[~2021-08-19 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 6:39 [PATCH] crypto: public_key: fix overflow during implicit conversion zhenwei pi
2021-08-18 8:33 ` PING: " zhenwei pi
2021-08-18 12:33 ` Jarkko Sakkinen
2021-08-18 23:35 ` Herbert Xu
2021-08-19 2:03 ` zhenwei pi
2021-08-19 10:35 ` Jarkko Sakkinen [this message]
2021-08-19 10:52 ` zhenwei pi
2021-08-19 11:44 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db55147350d81ed205d37031d81b03b80f639cc.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pizhenwei@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).