From: Joe Perches <joe@perches.com>
To: Tom Rix <trix@redhat.com>, clang-built-linux@googlegroups.com
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org,
tboot-devel@lists.sourceforge.net, kvm@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org,
devel@acpica.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
netdev@vger.kernel.org, linux-media@vger.kernel.org,
MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-wireless@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
keyrings@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, alsa-devel@alsa-project.org,
bpf@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-nfs@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [RFC] MAINTAINERS tag for cleanup robot
Date: Sun, 22 Nov 2020 10:22:36 -0800 [thread overview]
Message-ID: <859bae8ddae3238116824192f6ddf1c91a381913.camel@perches.com> (raw)
In-Reply-To: <6e8c1926-4209-8f10-d0f9-72c875a85a88@redhat.com>
On Sun, 2020-11-22 at 08:33 -0800, Tom Rix wrote:
> On 11/21/20 9:10 AM, Joe Perches wrote:
> > On Sat, 2020-11-21 at 08:50 -0800, trix@redhat.com wrote:
> > > A difficult part of automating commits is composing the subsystem
> > > preamble in the commit log. For the ongoing effort of a fixer producing
> > > one or two fixes a release the use of 'treewide:' does not seem appropriate.
> > >
> > > It would be better if the normal prefix was used. Unfortunately normal is
> > > not consistent across the tree.
> > >
> > > So I am looking for comments for adding a new tag to the MAINTAINERS file
> > >
> > > D: Commit subsystem prefix
> > >
> > > ex/ for FPGA DFL DRIVERS
> > >
> > > D: fpga: dfl:
> > I'm all for it. Good luck with the effort. It's not completely trivial.
> >
> > From a decade ago:
> >
> > https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/
> >
> > (and that thread started with extra semicolon patches too)
>
> Reading the history, how about this.
>
> get_maintainer.pl outputs a single prefix, if multiple files have the
> same prefix it works, if they don't its an error.
>
> Another script 'commit_one_file.sh' does the call to get_mainainter.pl
> to get the prefix and be called by run-clang-tools.py to get the fixer
> specific message.
It's not whether the script used is get_maintainer or any other script,
the question is really if the MAINTAINERS file is the appropriate place
to store per-subsystem patch specific prefixes.
It is.
Then the question should be how are the forms described and what is the
inheritance priority. My preference would be to have a default of
inherit the parent base and add basename(subsystem dirname).
Commit history seems to have standardized on using colons as the separator
between the commit prefix and the subject.
A good mechanism to explore how various subsystems have uses prefixes in
the past might be something like:
$ git log --no-merges --pretty='%s' -<commit_count> <subsystem_path> | \
perl -n -e 'print substr($_, 0, rindex($_, ":") + 1) . "\n";' | \
sort | uniq -c | sort -rn
Using 10000 for commit_count and drivers/scsi for subsystem_path, the
top 40 entries are below:
About 1% don't have a colon, and there is no real consistency even
within individual drivers below scsi. For instance, qla2xxx:
1 814 scsi: qla2xxx:
2 691 scsi: lpfc:
3 389 scsi: hisi_sas:
4 354 scsi: ufs:
5 339 scsi:
6 291 qla2xxx:
7 256 scsi: megaraid_sas:
8 249 scsi: mpt3sas:
9 200 hpsa:
10 190 scsi: aacraid:
11 174 lpfc:
12 153 scsi: qedf:
13 144 scsi: smartpqi:
14 139 scsi: cxlflash:
15 122 scsi: core:
16 110 [SCSI] qla2xxx:
17 108 ncr5380:
18 98 scsi: hpsa:
19 97
20 89 treewide:
21 88 mpt3sas:
22 86 scsi: libfc:
23 85 scsi: qedi:
24 84 scsi: be2iscsi:
25 81 [SCSI] qla4xxx:
26 81 hisi_sas:
27 81 block:
28 75 megaraid_sas:
29 71 scsi: sd:
30 69 [SCSI] hpsa:
31 68 cxlflash:
32 65 scsi: libsas:
33 65 scsi: fnic:
34 61 scsi: scsi_debug:
35 60 scsi: arcmsr:
36 57 be2iscsi:
37 53 atp870u:
38 51 scsi: bfa:
39 50 scsi: storvsc:
40 48 sd:
next prev parent reply other threads:[~2020-11-22 18:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 16:50 [RFC] MAINTAINERS tag for cleanup robot trix
2020-11-21 17:10 ` Joe Perches
2020-11-22 16:33 ` Tom Rix
2020-11-22 18:22 ` Joe Perches [this message]
2020-11-23 17:06 ` Tom Rix
2020-11-21 17:18 ` James Bottomley
2020-11-21 18:02 ` Joe Perches
2020-11-23 15:52 ` Jani Nikula
2020-11-23 16:17 ` Lukas Bulwahn
2020-11-22 3:23 ` Matthew Wilcox
2020-11-22 14:46 ` Tom Rix
2020-11-22 14:56 ` Matthew Wilcox
2020-11-22 16:10 ` Tom Rix
2020-11-22 16:49 ` James Bottomley
2020-11-22 18:23 ` Joe Perches
2020-11-22 22:33 ` Finn Thain
2020-11-23 0:53 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=859bae8ddae3238116824192f6ddf1c91a381913.camel@perches.com \
--to=joe@perches.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=cluster-devel@redhat.com \
--cc=coreteam@netfilter.org \
--cc=devel@acpica.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ecryptfs@vger.kernel.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keyrings@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tboot-devel@lists.sourceforge.net \
--cc=trix@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).