From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Wed, 23 Sep 2020 19:52:47 +0000 Subject: Re: [PATCH 5/9] fs: remove various compat readv/writev helpers Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20200923060547.16903-1-hch@lst.de> <20200923060547.16903-6-hch@lst.de> <20200923142549.GK3421308@ZenIV.linux.org.uk> <20200923143251.GA14062@lst.de> <20200923145901.GN3421308@ZenIV.linux.org.uk> <20200923163831.GO3421308@ZenIV.linux.org.uk> <20200923194755.GR3421308@ZenIV.linux.org.uk> In-Reply-To: <20200923194755.GR3421308@ZenIV.linux.org.uk> To: Al Viro Cc: Christoph Hellwig , Andrew Morton , Jens Axboe , David Howells , David Laight , Linux ARM , "linux-kernel@vger.kernel.org" , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linuxppc-dev , linux-s390 , sparclinux , linux-block , linux-scsi , Linux FS-devel Mailing List , linux-aio , io-uring@vger.kernel.org, linux-arch , Linux-MM , Networking , keyrings@vger.kernel.org, LSM List On Wed, Sep 23, 2020 at 9:48 PM Al Viro wrote: > FWIW, after playing with that for a while... Do we really want the > compat_sys_...() declarations to live in linux/compat.h? Most of > the users of that file don't want those; why not move them to > linux/syscalls.h? Sure, let's do that. The trend overall is to integrate the compat stuff more closely into where the native implementation lives, so this would just follow that trend. I think with Christoph's latest patches, about half of them are going away as well. > Reason: there's a lot more users of linux/compat.h than those of > linux/syscalls.h - it's pulled by everything in the networking stack, > for starters... Right, the network headers pull in almost everything else through multiple indirect inclusions, anything we can do to reduce that helps. Arnd