From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <keyrings-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4DDAFC433E0
	for <keyrings@archiver.kernel.org>; Thu, 21 Jan 2021 04:55:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id F3153238EC
	for <keyrings@archiver.kernel.org>; Thu, 21 Jan 2021 04:55:13 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730601AbhAUDw5 (ORCPT <rfc822;keyrings@archiver.kernel.org>);
        Wed, 20 Jan 2021 22:52:57 -0500
Received: from mail.kernel.org ([198.145.29.99]:51512 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2388702AbhATXt0 (ORCPT <rfc822;keyrings@vger.kernel.org>);
        Wed, 20 Jan 2021 18:49:26 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id F0B69221FE;
        Wed, 20 Jan 2021 23:48:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1611186522;
        bh=2BgVV18n0FiTAx3Ktk2+qq/+MuryRP60T+o5yjWBck4=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=tyAPTm4TVc8RBvCmozjOhaqCARYGaelqOnoxhCn1FdCSw3nMaWzQnnJgzAxfpJdL0
         dNc+PfScLbvgqk7iYIEyRL62sY+wPjr3sKcz+h+iDR/XvyRiQTNOcBM6hRJgjmqsqb
         sTo7XfeBp57TftPu0R7AvFoQb9+qXgdPmQJXfcrknC2Us2s4aK+5cHLTYFdzpLpfdp
         OsZP2xBSMEh6M+K/28nNnQPOqfiD0UHTo0LtejjLE5jgGgiswwd6lOxQb3IuL6aAov
         vJBJlI0N8oUAqe5BYZRr0ixWXSpaC4PcDH7azCxLw/tEztgTAagQoyGO2e2HaDSN2/
         1cvhhoB9t5TAw==
Date:   Thu, 21 Jan 2021 01:48:36 +0200
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= <mic@digikod.net>
Cc:     David Howells <dhowells@redhat.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "David S . Miller" <davem@davemloft.net>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        James Morris <jmorris@namei.org>,
        =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= <mic@linux.microsoft.com>,
        Mimi Zohar <zohar@linux.ibm.com>,
        "Serge E . Hallyn" <serge@hallyn.com>, keyrings@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH v3 05/10] certs: Replace K{U,G}IDT_INIT() with
 GLOBAL_ROOT_{U,G}ID
Message-ID: <YAjBVNxsZ7Zn2Ksi@kernel.org>
References: <20210114151909.2344974-1-mic@digikod.net>
 <20210114151909.2344974-6-mic@digikod.net>
 <YAe8cr7bS2Dn0RRn@kernel.org>
 <96550031-5183-e60f-f279-3475ab3851bc@digikod.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <96550031-5183-e60f-f279-3475ab3851bc@digikod.net>
Precedence: bulk
List-ID: <keyrings.vger.kernel.org>
X-Mailing-List: keyrings@vger.kernel.org

On Wed, Jan 20, 2021 at 12:17:28PM +0100, Mickaël Salaün wrote:
> 
> On 20/01/2021 06:15, Jarkko Sakkinen wrote:
> > On Thu, Jan 14, 2021 at 04:19:04PM +0100, Mickaël Salaün wrote:
> >> From: Mickaël Salaün <mic@linux.microsoft.com>
> >>
> >> Align with the new macros and add appropriate include files.
> >>
> >> Cc: David Woodhouse <dwmw2@infradead.org>
> >> Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
> >> Signed-off-by: David Howells <dhowells@redhat.com>
> > 
> > The commit message makes no sense. What you new macros?
> 
> What about "Use the new GLOBAL_ROOT_UID and GLOBAL_ROOT_GID definitions,
> and add appropriate include files."?

They were added in 2011 so you could just remove "the new". Otherwise,
WFM.

/Jarkko