From: Joe Perches <joe@perches.com>
To: Tom Rix <trix@redhat.com>,
dhowells@redhat.com, jarkko.sakkinen@linux.intel.com,
jmorris@namei.org, serge@hallyn.com, denkenz@gmail.com,
marcel@holtmann.org
Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KEYS: remove redundant memset
Date: Wed, 22 Jul 2020 20:20:00 +0000 [thread overview]
Message-ID: <b60f9b3e07b86d0f8631f6990f61b5172c43841f.camel@perches.com> (raw)
In-Reply-To: <e36c364e-22f4-c520-04da-ca1196fec049@redhat.com>
On Wed, 2020-07-22 at 13:10 -0700, Tom Rix wrote:
> On 7/22/20 1:02 PM, Joe Perches wrote:
> > On Wed, 2020-07-22 at 06:46 -0700, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > >
> > > Reviewing use of memset in keyctrl_pkey.c
> > >
> > > keyctl_pkey_params_get prologue code to set params up
> > >
> > > memset(params, 0, sizeof(*params));
> > > params->encoding = "raw";
> > >
> > > keyctl_pkey_query has the same prologue
> > > and calls keyctl_pkey_params_get.
> > >
> > > So remove the prologue.
> > >
> > > Fixes: 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")
> > At best, this is a micro optimization.
> Yes
> > How is this appropriate for a Fixes: line?
> Removing unneeded code is not a fix?
IMO: there's no "bug" here.
It's not a logic defect causing some unintended outcome.
It doesn't need backporting to stable branches.
Documentation/process/submitting-patches.rst-If your patch fixes a bug in a specific commit, e.g. you found an issue using
Documentation/process/submitting-patches.rst:``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
Documentation/process/submitting-patches.rst-the SHA-1 ID, and the one line summary.
next prev parent reply other threads:[~2020-07-22 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 13:46 [PATCH v2] KEYS: remove redundant memset trix
2020-07-22 20:02 ` Joe Perches
2020-07-22 20:10 ` Tom Rix
2020-07-22 20:20 ` Joe Perches [this message]
2020-07-23 2:39 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b60f9b3e07b86d0f8631f6990f61b5172c43841f.camel@perches.com \
--to=joe@perches.com \
--cc=denkenz@gmail.com \
--cc=dhowells@redhat.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=serge@hallyn.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).