From: Stefan Berger <stefanb@linux.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
linux-crypto@vger.kernel.org, patrick@puiterwijk.org
Subject: Re: [PATCH v3 2/3] x509: Add support for parsing x509 certs with NIST p256 keys
Date: Wed, 27 Jan 2021 17:39:06 -0500 [thread overview]
Message-ID: <d7f04b7a-75f4-fce8-b826-d268e522cf42@linux.ibm.com> (raw)
In-Reply-To: <20210127193152.GA27505@gondor.apana.org.au>
On 1/27/21 2:31 PM, Herbert Xu wrote:
> On Wed, Jan 27, 2021 at 07:33:49AM -0500, Stefan Berger wrote:
>> +static struct akcipher_alg ecc_nist_p256 = {
>> + .verify = ecdsa_verify,
>> + .set_pub_key = ecc_set_pub_key,
>> + .max_size = ecc_nist_p256_max_size,
>> + .init = ecc_nist_p256_init_tfm,
>> + .exit = ecc_exit_tfm,
>> + .base = {
>> + .cra_name = "nist_p256",
>> + .cra_driver_name = "ecc-nist-p256",
>> + .cra_priority = 100,
>> + .cra_module = THIS_MODULE,
>> + .cra_ctxsize = sizeof(struct ecc_ctx),
>> + },
>> +};
> This is not how we name generic algorithms.
Are saying that I cannot name it "nist_p256" but should call it 'ecdsa'
and the driver becomes "ecdsa-generic"?
>
> Please split this out and submit them through the crypto tree
> instead.
Will do.
>
> Thanks,
next prev parent reply other threads:[~2021-01-27 23:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 12:33 [PATCH v3 0/3] Add support for x509 certs with NIST p256 and p192 keys Stefan Berger
2021-01-27 12:33 ` [PATCH v3 1/3] x509: Detect sm2 keys by their parameters OID Stefan Berger
2021-01-30 21:26 ` Jarkko Sakkinen
2021-01-31 2:57 ` Stefan Berger
2021-02-02 15:16 ` Jarkko Sakkinen
2021-01-27 12:33 ` [PATCH v3 2/3] x509: Add support for parsing x509 certs with NIST p256 keys Stefan Berger
2021-01-27 19:31 ` Herbert Xu
2021-01-27 22:39 ` Stefan Berger [this message]
2021-01-27 12:33 ` [PATCH v3 3/3] x509: Add support for NIST p192 keys in certificates and akcipher Stefan Berger
2021-01-27 13:05 ` [PATCH v3 0/3] Add support for x509 certs with NIST p256 and p192 keys David Howells
2021-01-27 14:22 ` David Howells
2021-01-27 19:32 ` Herbert Xu
2021-01-27 21:08 ` David Howells
2021-01-27 16:12 ` Nym Seddon
2021-01-27 22:42 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7f04b7a-75f4-fce8-b826-d268e522cf42@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@puiterwijk.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).