From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 320F0C636D3 for ; Wed, 8 Feb 2023 04:35:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbjBHEfv (ORCPT ); Tue, 7 Feb 2023 23:35:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229700AbjBHEfu (ORCPT ); Tue, 7 Feb 2023 23:35:50 -0500 Received: from bedivere.hansenpartnership.com (bedivere.hansenpartnership.com [IPv6:2607:fcd0:100:8a00::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A4ED2683; Tue, 7 Feb 2023 20:35:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1675830946; bh=f39yvrDOmv2DvucwTqX2uN2hj74AJ8aPcBfQJHQiUZY=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=i4WXCZI+saBtiwshZWYbmeryRfBudnTyVB3ZMC18KNwMr4AYTefFzwtwM5KN0yV7e 3yuAwCMcqYRa7Yovad1blDMZihSPr7avyTWz1gYFc6eTTvG7O+qNrYP0adS7hwsWnc BSf0K9PWgjc92kRP7MEUcKdmEpPpyiouB5ezF/BE= Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 8BEE412891EF; Tue, 7 Feb 2023 23:35:46 -0500 (EST) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i9IS57eTWRkI; Tue, 7 Feb 2023 23:35:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1675830946; bh=f39yvrDOmv2DvucwTqX2uN2hj74AJ8aPcBfQJHQiUZY=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=i4WXCZI+saBtiwshZWYbmeryRfBudnTyVB3ZMC18KNwMr4AYTefFzwtwM5KN0yV7e 3yuAwCMcqYRa7Yovad1blDMZihSPr7avyTWz1gYFc6eTTvG7O+qNrYP0adS7hwsWnc BSf0K9PWgjc92kRP7MEUcKdmEpPpyiouB5ezF/BE= Received: from [172.20.6.85] (unknown [176.236.36.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 6945112891EE; Tue, 7 Feb 2023 23:35:44 -0500 (EST) Message-ID: Subject: Re: [PATCH v2 06/11] tpm: Add full HMAC and encrypt/decrypt session handling code From: James Bottomley To: Yujie Liu Cc: kernel test robot , linux-integrity@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Jarkko Sakkinen , keyrings@vger.kernel.org, Ard Biesheuvel Date: Wed, 08 Feb 2023 07:35:40 +0300 In-Reply-To: References: <20230124175516.5984-7-James.Bottomley@HansenPartnership.com> <202301250706.deGvd0yq-lkp@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org On Fri, 2023-02-03 at 14:06 +0800, Yujie Liu wrote: > Hi James, > > On Wed, Jan 25, 2023 at 07:59:09AM -0500, James Bottomley wrote: > > On Wed, 2023-01-25 at 07:11 +0800, kernel test robot wrote: > > > Hi James, > > > > > > I love your patch! Perhaps something to improve: > > > > > > [auto build test WARNING on char-misc/char-misc-testing] > > > [also build test WARNING on char-misc/char-misc-next char- > > > misc/char- > > > misc-linus zohar-integrity/next-integrity linus/master v6.2-rc5 > > > next- > > > 20230124] > > > [If your patch is applied to the wrong git tree, kindly drop us a > > > note. > > > And when submitting patch, we suggest to use '--base' as > > > documented > > > in > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > > > url:    > > > https://github.com/intel-lab-lkp/linux/commits/James-Bottomley/tpm-move-buffer-handling-from-static-inlines-to-real-functions/20230125-020146 > > > patch link:    > > > https://lore.kernel.org/r/20230124175516.5984-7-James.Bottomley%40HansenPartnership.com > > > patch subject: [PATCH v2 06/11] tpm: Add full HMAC and > > > encrypt/decrypt session handling code > > > config: arc-allyesconfig > > > ( > > > https://download.01.org/0day-ci/archive/20230125/202301250706.deGv > > > d0 > > > yq-lkp@intel.com/config) > > > compiler: arceb-elf-gcc (GCC) 12.1.0 > > > reproduce (this is a W=1 build): > > >         wget > > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > > >  -O ~/bin/make.cross > > >         chmod +x ~/bin/make.cross > > >         # > > > https://github.com/intel-lab-lkp/linux/commit/dc0fc74718b4a786aba4a954233e8ab3afdcc03c > > >         git remote add linux-review > > > https://github.com/intel-lab-lkp/linux > > >         git fetch --no-tags linux-review James-Bottomley/tpm- > > > move- > > > buffer-handling-from-static-inlines-to-real-functions/20230125- > > > 020146 > > >         git checkout dc0fc74718b4a786aba4a954233e8ab3afdcc03c > > >         # save the config file > > >         mkdir build_dir && cp config build_dir/.config > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 > > > make.cross W=1 O=build_dir ARCH=arc olddefconfig > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 > > > make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash > > > drivers/char/tpm/ > > > > > > If you fix the issue, kindly add following tag where applicable > > > > Reported-by: kernel test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > >    drivers/char/tpm/tpm2-sessions.c:1184:5: warning: no previous > > > prototype for 'tpm2_create_null_primary' [-Wmissing-prototypes] > > >     1184 | int tpm2_create_null_primary(struct tpm_chip *chip) { > > >          |     ^~~~~~~~~~~~~~~~~~~~~~~~ > > >    drivers/char/tpm/tpm2-sessions.c: In function > > > 'tpm_buf_check_hmac_response': > > > > > drivers/char/tpm/tpm2-sessions.c:831:1: warning: the frame > > > > > size > > > > > of 1132 bytes is larger than 1024 bytes [-Wframe-larger- > > > > > than=] > > >      831 | } > > >          | ^ > > >    drivers/char/tpm/tpm2-sessions.c: In function > > > 'tpm_buf_fill_hmac_session': > > >    drivers/char/tpm/tpm2-sessions.c:579:1: warning: the frame > > > size of > > > 1132 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > >      579 | } > > >          | ^ > > > > Is this a test problem?  I can't see why the code would only blow > > the stack on the arc architecture and not on any other ... does it > > have something funny with on stack crypto structures? > > This warning is controlled by the value of CONFIG_FRAME_WARN. > > For "make ARCH=arc allyesconfig", the default value is 1024, so this > frame warning shows up during the build. > > For other arch such as "make ARCH=x86_64 allyesconfig", the default > value would be 2048 and won't have this warning. > > Not sure if this is a real problem that need to be fixed, here just > providing above information for your reference. Is there something weird about arc, though, since a quick trawl through defconfigs shows quite a few systems (including i386) have it set to 1024: mips/configs/lemote2f_defconfig:CONFIG_FRAME_WARN=1024 mips/configs/loongson2k_defconfig:CONFIG_FRAME_WARN=1024 powerpc/configs/fsl-emb-nonhw.config:CONFIG_FRAME_WARN=1024 um/configs/x86_64_defconfig:CONFIG_FRAME_WARN=1024 x86/configs/i386_defconfig:CONFIG_FRAME_WARN=1024 That also seems to show, by the way, that the default on arc should be the standard 2048. James