From: James Bottomley <James.Bottomley@HansenPartnership.com> To: Matthew Wilcox <email@example.com> Cc: Vlastimil Babka <firstname.lastname@example.org>, ksummit <email@example.com>, LKML <firstname.lastname@example.org> Subject: Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch Date: Thu, 03 Dec 2020 12:04:08 -0800 [thread overview] Message-ID: <147e17a3a1e54d46611b285a973c03f14b19dc96.camel@HansenPartnership.com> (raw) In-Reply-To: <CAFhKne9ZSbwrH6-g7og2BBEEDGd6ScDnZTNg3znQLvLDCDfeoA@mail.gmail.com> On Thu, 2020-12-03 at 13:52 -0500, Matthew Wilcox wrote: > It's not so much "clean history" that's the desire. It's "don't leave > landmines for git bisect". ... top posting? Well functional git bisect and show the evolution of the patch aren't mutually exclusive. Plus our current clean history approach doesn't always detect them ... That said, I agree that if a review comes in that shows a patch would break the build or runtime in a way that would damage bisection, it should be folded. I suppose this argues that only less trivial changes can be shown as part of the unfolded history, and since they're obviously less important than the review driven folded change it would add more bias to track them. I fall back to my link is enough comment. James _______________________________________________ Ksummit-discuss mailing list Ksummitemail@example.com https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
next prev parent reply other threads:[~2020-12-03 20:04 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-02 23:43 Vlastimil Babka 2020-12-03 4:02 ` Dan Williams 2020-12-03 9:34 ` Leon Romanovsky 2020-12-03 9:36 ` Geert Uytterhoeven 2020-12-03 10:40 ` Leon Romanovsky 2020-12-03 18:30 ` Greg KH 2020-12-03 19:04 ` Leon Romanovsky 2020-12-09 0:34 ` Kees Cook 2020-12-09 5:01 ` Joe Perches 2020-12-09 7:58 ` Dan Carpenter 2020-12-09 8:45 ` Vlastimil Babka 2020-12-09 9:18 ` Geert Uytterhoeven 2020-12-09 8:54 ` Joe Perches 2020-12-09 10:30 ` Dan Carpenter 2020-12-09 17:45 ` Dan Williams 2020-12-03 10:33 ` Dan Carpenter 2020-12-03 13:41 ` Julia Lawall 2020-12-03 13:58 ` James Bottomley 2020-12-03 16:55 ` Joe Perches 2020-12-03 19:17 ` Konstantin Ryabitsev 2020-12-03 19:24 ` Joe Perches 2020-12-03 21:13 ` James Bottomley 2020-12-03 18:52 ` Matthew Wilcox 2020-12-03 20:04 ` James Bottomley [this message] 2020-12-04 4:54 ` Theodore Y. Ts'o
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=147e17a3a1e54d46611b285a973c03f14b19dc96.camel@HansenPartnership.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).