From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 615BA1B9B for ; Wed, 28 Aug 2019 08:57:52 +0000 (UTC) Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 07422EC for ; Wed, 28 Aug 2019 08:57:51 +0000 (UTC) Date: Wed, 28 Aug 2019 11:57:25 +0300 From: Dan Carpenter To: "Paul E. McKenney" Message-ID: <20190828085725.GG23584@kadam> References: <20190826230206.GC28066@mit.edu> <20190827142826.GD26530@linux.ibm.com> <20190827152505.GE26530@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190827152505.GE26530@linux.ibm.com> Cc: Joel Fernandes , Barret Rhoden , ksummit , Greg Kroah-Hartman , Jonathan Nieder , Tomasz Figa , Han-Wen Nienhuys , Theodore Tso , David Rientjes , Dmitry Torokhov , Dmitry Vyukov Subject: Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Aug 27, 2019 at 08:25:05AM -0700, Paul E. McKenney wrote: > Someone then reviews the patch and reports a bug. I update the > commit with a fix. Now what I do is this: > > [ paulmck: Update based on blablabla feedback from So And So. ] It sort of bothers me that there isn't a proper tag for these so they're are not searchable. Last week I fixed a bug and a reviewer noticed that there was a similar issue earlier in the function so I fixed that as well and sent a v2 but he only gets Reviewed-by credit. Reviewed-by is the lamest sort of credit. It should be that reviewers get credit for finding bugs in patches (no credit for complaining about checkpatch issues, that is its own reward). regards, dan carpenter