From: Kees Cook <keescook@chromium.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: ksummit-discuss@lists.linuxfoundation.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
SeongJae Park <sjpark@amazon.de>,
linux-kernel@vger.kernel.org,
tech-board-discuss@lists.linuxfoundation.org,
Chris Mason <clm@fb.clm>, Dave Airlie <airlied@redhat.com>
Subject: Re: [Ksummit-discuss] [PATCH v2] CodingStyle: Inclusive Terminology
Date: Wed, 8 Jul 2020 01:22:27 -0700 [thread overview]
Message-ID: <202007080108.454C937@keescook> (raw)
In-Reply-To: <159419296487.2464622.863943877093636532.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, Jul 08, 2020 at 12:23:59AM -0700, Dan Williams wrote:
> Linux maintains a coding-style and its own idiomatic set of terminology.
> Update the style guidelines to recommend replacements for the terms
> master/slave and blacklist/whitelist.
>
> Link: http://lore.kernel.org/r/159389297140.2210796.13590142254668787525.stgit@dwillia2-desk3.amr.corp.intel.com
> Cc: Jonathan Corbet <corbet@lwn.net>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Dave Airlie <airlied@redhat.com>
> Acked-by: Kees Cook <keescook@chromium.org>
> Acked-by: SeongJae Park <sjpark@amazon.de>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Chris Mason <clm@fb.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> Changes since v1 [1]
> - Drop inclusive-terminology.rst, it is in the lore archives if the
> arguments are needed for future debates, but otherwise no pressing
> need to carry it in the tree (Linus, James)
>
> - Update the recommended terms to include replacement for 'master' and
> 'whitelist' (Kees, Andy)
>
> - Add 'target' as a replacement (Andy)
>
> - Add 'device' as a replacement (Mark)
>
> - Collect acks and signed-off-bys. Yes, the sign-offs are not reflective
> of a submission chain, but I kept "Signed-off-by" if people offered
> it.
In that case, I will "upgrade" my Ack. ;)
Signed-off-by: Kees Cook <keescook@chromium.org>
:)
> - Non-change: I did not add explicit language as to what to do with
> existing usages. My personal inclination is to prioritize this
> coding-style cleanup higher than others, but the coding-style document
> has typically not indicated policy on how cleanups are handled by
> subsystems. It will be a case by case effort and consideration.
While I'd like to have published guidance on fixing existing language
(which is already underway[1]), I agree: let's start here.
> [...]
> +For symbol names, avoid introducing new usage of 'master/slave' (or
For symbol names, comments, documentation, and other language, avoid
introducing ...
> +'slave' independent of 'master') and 'blacklist/whitelist'. Recommended
> +replacements for 'master/slave' are: 'main/{secondary,subordinate}',
> +'primary/replica', '{initiator,requester}/{target,responder}',
the main and primary should be merged, IMO:
'{primary,main}/{secondary,replica,subordinate}'
> +'host/{device,proxy}', or 'leader/{performer,follower}'. Recommended
leader/performer does not track for me. Split it out?
'leader/follower', 'director/performer'
I have also seen:
'controller/worker'
Thanks!
-Kees
[1] https://lore.kernel.org/lkml/20200630174123.GA1906678@kroah.com/
https://lore.kernel.org/lkml/20200701171555.3198836-1-gregkh@linuxfoundation.org/
--
Kees Cook
_______________________________________________
Ksummit-discuss mailing list
Ksummit-discuss@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
next prev parent reply other threads:[~2020-07-08 8:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 7:23 [Ksummit-discuss] [PATCH v2] CodingStyle: Inclusive Terminology Dan Williams
2020-07-08 7:52 ` Dan Williams
2020-07-08 8:22 ` Kees Cook [this message]
2020-07-08 14:43 ` Dan Williams
2020-07-08 9:30 ` [Ksummit-discuss] [Tech-board-discuss] " Mark Brown
2020-07-08 10:07 ` [Ksummit-discuss] " Dan Carpenter
2020-07-08 11:04 ` Joe Perches
2020-07-08 15:14 ` Dan Williams
2020-07-08 15:59 ` [Ksummit-discuss] [Tech-board-discuss] " James Bottomley
2020-07-08 14:22 ` [Ksummit-discuss] " tytso
2020-07-08 16:23 ` Christian Brauner
2020-07-08 16:42 ` [Ksummit-discuss] [Tech-board-discuss] " Shuah Khan
2020-07-08 18:59 ` [Ksummit-discuss] " Stephen Hemminger
2020-07-10 16:02 ` Linus Walleij
2020-07-10 16:13 ` Dan Williams
2020-07-11 13:30 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007080108.454C937@keescook \
--to=keescook@chromium.org \
--cc=airlied@redhat.com \
--cc=clm@fb.clm \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sjpark@amazon.de \
--cc=tech-board-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).