From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 1051ED38 for ; Fri, 23 Aug 2019 16:54:13 +0000 (UTC) Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9D22967F for ; Fri, 23 Aug 2019 16:54:12 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id s14so8740645qkm.4 for ; Fri, 23 Aug 2019 09:54:12 -0700 (PDT) MIME-Version: 1.0 References: <20190823013619.GA8130@mit.edu> <20190823151843.GH8130@mit.edu> <20190823161947.GA112509@dtor-ws> In-Reply-To: From: Joel Fernandes Date: Fri, 23 Aug 2019 12:54:00 -0400 Message-ID: To: Doug Anderson Content-Type: text/plain; charset="UTF-8" Cc: Barret Rhoden , ksummit , Greg Kroah-Hartman , Jonathan Nieder , Tomasz Figa , Han-Wen Nienhuys , Theodore Tso , David Rientjes , Dmitry Torokhov , Dmitry Vyukov Subject: Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Aug 23, 2019 at 12:45 PM Doug Anderson wrote: [snip] > Sure, if a given patch in the series is totally wrong and I re-write > it (but still want the re-write to be considered a new version of the > previous patch) then I have to manually copy the Change-Id for a > gerrit upload. ...but I'd also be OK if people just get a new > Change-Id in this case. Sometimes it is not "totally wrong" but just "done in a different away" and is a new series. This happens a lot since upstream development can be evolutionary. So your v1 may look nothing like v2 and is a whole new series. Yet the history linking the 2 series is important. And no amount of automated commit ID generation can link them. This is the scenario I was talking about. I know the git hook works, but sometimes the Change-Id has to be manually copied. That's not automatable. May be we are slightly on different tracks, but this is the scenario that would be useful to trace IMO.