From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4117872 for ; Mon, 19 Jul 2021 21:31:51 +0000 (UTC) Received: from mail-wm1-f41.google.com ([209.85.128.41]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MVv8f-1ldiBn0W3h-00RoAU for ; Mon, 19 Jul 2021 23:31:50 +0200 Received: by mail-wm1-f41.google.com with SMTP id l18-20020a1ced120000b029014c1adff1edso296969wmh.4 for ; Mon, 19 Jul 2021 14:31:50 -0700 (PDT) X-Gm-Message-State: AOAM531Oim8rYpK770ZcHebnYRrqkKORd8bjA3Gh2z/s6T11bmtsnUtW uWxpzHsisUTqfD/WM/XS0HpQjKEBczmLMNDIkzw= X-Google-Smtp-Source: ABdhPJxT1xrTWIAPQ1nOIEu0P4H2Dbd0NKelYDeI2r4w3Wmlwbbv8+OUHdg7fr/SiF0P9gNDJlpAy0Hf+vIe6aepiWo= X-Received: by 2002:a7b:c2fa:: with SMTP id e26mr34255437wmk.84.1626730309821; Mon, 19 Jul 2021 14:31:49 -0700 (PDT) Precedence: bulk X-Mailing-List: ksummit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Mon, 19 Jul 2021 23:31:33 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [TECH TOPIC] Rust for Linux To: Wedson Almeida Filho Cc: Arnd Bergmann , Linus Walleij , Miguel Ojeda , Greg KH , Bartosz Golaszewski , Kees Cook , Jan Kara , James Bottomley , Julia Lawall , Laurent Pinchart , Roland Dreier , ksummit@lists.linux.dev, Viresh Kumar Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:JTkfFVpJl4nRoB7BPOInnSBrIhD9HBJMo+9Z2ourPoSzOS/F0td PzeBbe74n6JYy5A/JGFTag+sNU+EJQrQRf6LPBh4pAWDoMq5+NTAEFQLCjLhlQVc51HHfUF G5lwYYnx2fTDokYLO0VVpq2goThNPXojh2tcCAkd6Na54xCtYwIDfEvCLEnIvFne68tOEWh vOJ9LsbytwqKvumgPmVtw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:fKE3i9q4npg=:Fs5DBE5DsRX/mIOladvriZ 2+NQZBvGKN/AKJUhcSNJJStvLyFgu8UcVw3Xwhjts7bhH9BBCFpcI/jAM1WKHRlhWXHeIfBaV HN8161OKj5rvHXAYvFTky+z0oN+aR/89ZFPBjmnRB1LqJXtmH31dt9YJakuuHLtfjZXM2Jm6N fGp9SkFyCLHCWDiW6OpcNmKcgJqNZ5wy4QwiCYMeVZhlC9/dYypH7nU0wRSeVzqn8mguwwgXj ysF39//WoUXg6AqD0X9T1DaTJ8sBCe7UiqF73tVaimRQkLQ3juHzsy3Wla7QhKvoP7IYYV9me oOzzYn1QX2NK0iv1G3WwCjw7aG2Q/6aIYcFMVvgNXKlryiw08RW0cv4OPvJbhVnObPZs5OcSs DdRJ2G8Eqf2aSECk/6M1syzoHFWLy7KNb2V2jNqw2kUreUqF19R8rfivI0f2tYFZayQQOcETt c2oIE7bOpwUrd7zVibp9MrNk7ncuUZTn81t5zhtF5RpLTfAIDbk+OJixeAjqZRZ9ibKsrDv01 ry0jUVDljwGqab8Z8J4o8e57F4uCBh5JNCJrW1b9ZtaOsyRh/V4HXq0vBZM8OL6N/ZFrBQybn tIGp3dHxjpifzHFejf9SZN0Xaf5QpwMBGNhR1HQhacf1WXFUiHoiMlUsESbMnsVqlhIn6PMwr g1Ssx0xqHfjQhCYOGSs+XmG8HEDLFLMmnGc6KdfD5fdOxbeyYtqUeyW0ZR6QHCR8ecqO0fmSg LzLtJ1xqkwbuOFcYx5Ungu08zsn1E1wIVvfMCDbTWNmTSz4XuL6OJqYYxJcU8y/PvBnz3154p +ToqbgTkarWXHf/7vFgHDXiy/rEe6hmYElyNX2xo03qJcswRNeSEz15Q3trsemjHP+OM56CUP G42hjTGnw4cgItNbq5/hdXbHQUGglQAiFkjR95UtxC+Bn4w310Rzd3HvADZiAM+GE749IPwfP 0euEuqli8+uhMvxRi7Bfigvrow8kzLOy+nWh9QG4H6MFroQ+ZSr5R On Mon, Jul 19, 2021 at 7:32 PM Wedson Almeida Filho wrote: > On Mon, Jul 19, 2021 at 04:02:38PM +0200, Arnd Bergmann wrote: > > At the moment we lose information about the device, but simply because we > haven't implemented dev_ variants yet, there is no fundamental reason for this > though. > ... > > Yes, it uses spinlock_t. But again, just because we don't have an implementation > that uses raw_spinlock_t yet. > ... > It's not there yet, but the idea is to wrap the place where `drv.pm` is > initialised in the amba code with `if cfg!(CONFIG_PM)` -- if CONFIG_PM is > disabled, all references to PM code are gone and they are removed by the > compiler. This way we move configuration-dependent code out of drivers and into > core libraries. Ok, that all sounds good to me. I'll reply separately on the coding style. Arnd