From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF52C63777 for ; Thu, 3 Dec 2020 09:37:15 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D57E20872 for ; Thu, 3 Dec 2020 09:37:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D57E20872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ksummit-discuss-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id AB8EF20454; Thu, 3 Dec 2020 09:37:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nj86-xDeBsQD; Thu, 3 Dec 2020 09:37:11 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 40470203BD; Thu, 3 Dec 2020 09:37:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 12F01C163C; Thu, 3 Dec 2020 09:37:11 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 15F3FC0FA7 for ; Thu, 3 Dec 2020 09:37:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 11DB487746 for ; Thu, 3 Dec 2020 09:37:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PQQ-3xlQQQoo for ; Thu, 3 Dec 2020 09:37:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by hemlock.osuosl.org (Postfix) with ESMTPS id 0E07187293 for ; Thu, 3 Dec 2020 09:37:09 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id k26so1563842oiw.0 for ; Thu, 03 Dec 2020 01:37:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jvny1rtUiDgjADL0gl6coThE7hbff0ih3DlnnP8/5jo=; b=ZesgbikrDJ672KkeVE9Wyy+9+6+8yzf0lZk83Kv2CHzsHW642QvDvhJO1C9I6GDscw ZX7CYW2HAlRRyIJh0VOWEI2YJVUBEeYDEuNm6ATK8Eqa1qIxnmyJ5c/pRQ/fQXk4A7G3 FwpG1SvAQgJVowe6x3Cf9H+P5v0PUa24moIt+dfOlrMAFLbsfht/rlTAPhkkKw/fv4eJ jCFpgFYppuZEQzNhn3YgDOH9Na6MrhEyMeDdsOvymY2N4VrSv0fFWdcXGZAffJj7RA2c 3wEy9PzwBFSVGPgp6D7N5pOAT/YXfjA04ifMP1S0M/BfKncADzsVXU+oP3QdWTkHUTk0 QbKw== X-Gm-Message-State: AOAM532GJTe6HwcEY2iMVvJPj70aB7GzKP5XfY4EJ2XbBbmWFfyBZNVy S6fvLf8oiI2TU3IhF4IjVVovO+o4484U8O1n4zo= X-Google-Smtp-Source: ABdhPJw4GKrS5Viye7DaliTruHqlREe1NdLISwc/nLmA8wqlEaJsNx9bI4Esu7LyGFrsK/31Ymq2sbT3Qb2UsLRC6Kc= X-Received: by 2002:aca:ec09:: with SMTP id k9mr1271015oih.153.1606988228261; Thu, 03 Dec 2020 01:37:08 -0800 (PST) MIME-Version: 1.0 References: <20201203093458.GA16543@unreal> In-Reply-To: <20201203093458.GA16543@unreal> From: Geert Uytterhoeven Date: Thu, 3 Dec 2020 10:36:56 +0100 Message-ID: To: Leon Romanovsky Cc: Vlastimil Babka , LKML , "ksummit-discuss@lists.linuxfoundation.org" Subject: Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch X-BeenThere: ksummit-discuss@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ksummit-discuss-bounces@lists.linuxfoundation.org Sender: "Ksummit-discuss" On Thu, Dec 3, 2020 at 10:35 AM Leon Romanovsky wrote: > On Wed, Dec 02, 2020 at 08:02:27PM -0800, Dan Williams wrote: > > On Wed, Dec 2, 2020 at 3:44 PM Vlastimil Babka wrote: > > > there was a bit of debate on Twitter about this, so I thought I would bring it > > > here. Imagine a scenario where patch sits as a commit in -next and there's a bug > > > report or fix, possibly by a bot or with some static analysis. The maintainer > > > decides to fold it into the original patch, which makes sense for e.g. > > > bisectability. But there seem to be no clear rules about attribution in this > > > case, which looks like there should be, probably in > > > Documentation/maintainer/modifying-patches.rst > > > > > > The original bug fix might include a From: $author, a Reported-by: (e.g. > > > syzbot), Fixes: $next-commit, some tag such as Addresses-Coverity: to credit the > > > static analysis tool, and an SoB. After folding, all that's left might be a line > > > as "include fix from $author" in the SoB area. This is a loss of > > > metadata/attribution just due to folding, and might make contributors unhappy. > > > Had they sent the fix after the original commit was mainline and immutable, all > > > the info above would "survive" in the form of new commit. > > > > > > So I think we could decide what the proper format would be, and document it > > > properly. I personally wouldn't mind just copy/pasting the whole commit message > > > of the fix (with just a short issue description, no need to include stacktraces > > > etc if the fix is folded), we could just standardize where, and how to delimit > > > it from the main commit message. If it's a report (person or bot) of a bug that > > > the main author then fixed, preserve the Reported-by in the same way (making > > > clear it's not a Reported-By for the "main thing" addressed by the commit). > > > > > > In the debate one less verbose alternatve proposed was a SoB with comment > > > describing it's for a fix and not whole patch, as some see SoB as the main mark > > > of contribution, that can be easily found and counted etc. I'm not so sure about > > > it myself, as AFAIK SoB is mainly a DCO thing, and for a maintainer it means > > > something else ("passed through my tree") than for a patch author. And this > > > approach would still lose the other tags. > > > > > > Thoughts? > > > > How about a convention to add a Reported-by: and a Link: to the > > incremental fixup discussion? It's just polite to credit helpful > > feedback, not sure it needs a more formal process. > > Maybe "Fixup-Reported-by:" and "Fixup-Link:"? And "Earlier-Review-Comments-Provided-by:"? How far do we want to go? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ Ksummit-discuss mailing list Ksummit-discuss@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss