From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 173D8E4A for ; Fri, 23 Aug 2019 13:16:13 +0000 (UTC) Received: from mail-yw1-f65.google.com (mail-yw1-f65.google.com [209.85.161.65]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8FB1B89B for ; Fri, 23 Aug 2019 13:16:12 +0000 (UTC) Received: by mail-yw1-f65.google.com with SMTP id z64so3796360ywe.7 for ; Fri, 23 Aug 2019 06:16:12 -0700 (PDT) Received: from mail-yw1-f43.google.com (mail-yw1-f43.google.com. [209.85.161.43]) by smtp.gmail.com with ESMTPSA id j3sm533689ywf.35.2019.08.23.06.16.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2019 06:16:10 -0700 (PDT) Received: by mail-yw1-f43.google.com with SMTP id i138so3792002ywg.8 for ; Fri, 23 Aug 2019 06:16:09 -0700 (PDT) MIME-Version: 1.0 References: <20190823013619.GA8130@mit.edu> In-Reply-To: From: Sean Paul Date: Fri, 23 Aug 2019 09:15:30 -0400 Message-ID: To: Linus Torvalds Content-Type: text/plain; charset="UTF-8" Cc: Joel Fernandes , Barret Rhoden , ksummit , Greg Kroah-Hartman , Jonathan Nieder , Tomasz Figa , Han-Wen Nienhuys , Theodore Tso , David Rientjes , Dmitry Torokhov , Dmitry Vyukov Subject: Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Aug 22, 2019 at 11:04 PM Linus Torvalds wrote: > > On Thu, Aug 22, 2019 at 7:58 PM Linus Torvalds > wrote: > > > > So yes, I'd *much* rather see that "Link" line than try to make a > > "Change-ID" line be a thing. > > Tangential note: since it looks like "Link:" lines are going to get > more common in general, maybe somebody with the right tck/tk-fu can > make a tool like 'gitk' be able to just do the hyperlinking thing (it > already does it for commit hashes in the commit message, but wouldn't > it be convenient to do that for web links too and open a browser > tab?). > > And maybe we can even make git.kernel.org do it too (I think that uses cgit?). > > I think that might make it just nicer in general to browse the logs > and actually follow the links without cut-and-paste games.. > > So using a generic "Link:" tag that can be used for multiple different > things sounds like a win in general over some specialized change-ID > tag. No? Only if you've uploaded the patch somewhere before sending it to the mailing list. I think this would satisfy the Gerrit crowd, since they're presumably uploading the patch to Gerrit, getting some review on it and then sending it upstream. They will have a link. If you're just interested in being archival tool friendly, you probably just want to add some uuid cookie to the patch and post it directly to the mailing list. That said, I don't think Change-Id (or Uuid or whatever the cookie tag is named) needs to be committed to git. If people stuck their Change-Id tag below '---' in their mail, it would solve the issue of finding old revisions on the list. This would also allow tooling (like patchwork) to track across revisions. It's pretty easy to work backwards from a commit to _any_ one revision of the patch on the m-l, and that will give you the Change-Id. If Change-Id becomes widely useful below '---', you could add support in patchwork to allow direct linking by Change-Id. This would allow people to add Link: to their commit messages without first uploading it somewhere. Sean > > Linus > _______________________________________________ > Ksummit-discuss mailing list > Ksummit-discuss@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss