From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>, Nico Boehr <nrb@linux.ibm.com>,
kvm@vger.kernel.org
Cc: imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v3 1/1] s390x: verify EQBS/SQBS is unavailable
Date: Thu, 8 Sep 2022 14:43:43 +0200 [thread overview]
Message-ID: <003c5ac1-5215-0529-b125-e3fbd478d6d2@linux.ibm.com> (raw)
In-Reply-To: <b238301e-3f43-062e-920d-d322548c55ba@linux.ibm.com>
Am 24.08.22 um 09:40 schrieb Janosch Frank:
> On 8/4/22 00:17, Thomas Huth wrote:
>> On 03/08/2022 15.58, Nico Boehr wrote:
>>> QEMU doesn't provide EQBS/SQBS instructions, so we should check they
>>> result in an exception.
>>
>> I somewhat fail to see the exact purpose of this patch... QEMU still doesn't
>> emulate a lot of other instructions, too, so why are we checking now these
>> QBS instructions? Why not all the others? Why do we need a test to verify
>> that there is an exception in this case - was there a bug somewhere that
>> didn't cause an exception in certain circumstances?
>
> Looking at the patch that introduced the QEMU handlers (1eecf41b) I wonder why those two cases were added. From my point of view it makes sense to remove the special handling for those two instructions.
>
> @Christian: Any idea why this was added? Can we remove it?
No idea why it was added (in an always fail way). Yes we could remove it until we need it.
prev parent reply other threads:[~2022-09-08 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 13:58 [kvm-unit-tests PATCH v3 0/1] s390x: verify EQBS/SQBS is unavailable Nico Boehr
2022-08-03 13:58 ` [kvm-unit-tests PATCH v3 1/1] " Nico Boehr
2022-08-03 17:23 ` Claudio Imbrenda
2022-08-03 22:17 ` Thomas Huth
2022-08-09 6:20 ` Nico Boehr
2022-08-24 7:40 ` Janosch Frank
2022-08-24 8:31 ` Thomas Huth
2022-09-08 12:43 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=003c5ac1-5215-0529-b125-e3fbd478d6d2@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).