* [PATCH] selftests/kvm: make platform_info_test pass on AMD
@ 2019-06-10 17:22 Vitaly Kuznetsov
2019-08-21 16:10 ` Vitaly Kuznetsov
0 siblings, 1 reply; 3+ messages in thread
From: Vitaly Kuznetsov @ 2019-06-10 17:22 UTC (permalink / raw)
To: kvm; +Cc: linux-kernel, Paolo Bonzini, Radim Krčmář
test_msr_platform_info_disabled() generates EXIT_SHUTDOWN but VMCB state
is undefined after that so an attempt to launch this guest again from
test_msr_platform_info_enabled() fails. Reorder the tests to make test
pass.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
tools/testing/selftests/kvm/x86_64/platform_info_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kvm/x86_64/platform_info_test.c b/tools/testing/selftests/kvm/x86_64/platform_info_test.c
index 40050e44ec0a..f9334bd3cce9 100644
--- a/tools/testing/selftests/kvm/x86_64/platform_info_test.c
+++ b/tools/testing/selftests/kvm/x86_64/platform_info_test.c
@@ -99,8 +99,8 @@ int main(int argc, char *argv[])
msr_platform_info = vcpu_get_msr(vm, VCPU_ID, MSR_PLATFORM_INFO);
vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO,
msr_platform_info | MSR_PLATFORM_INFO_MAX_TURBO_RATIO);
- test_msr_platform_info_disabled(vm);
test_msr_platform_info_enabled(vm);
+ test_msr_platform_info_disabled(vm);
vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, msr_platform_info);
kvm_vm_free(vm);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/kvm: make platform_info_test pass on AMD
2019-06-10 17:22 [PATCH] selftests/kvm: make platform_info_test pass on AMD Vitaly Kuznetsov
@ 2019-08-21 16:10 ` Vitaly Kuznetsov
2019-08-21 17:06 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Vitaly Kuznetsov @ 2019-08-21 16:10 UTC (permalink / raw)
To: kvm; +Cc: linux-kernel, Paolo Bonzini, Radim Krčmář
Vitaly Kuznetsov <vkuznets@redhat.com> writes:
> test_msr_platform_info_disabled() generates EXIT_SHUTDOWN but VMCB state
> is undefined after that so an attempt to launch this guest again from
> test_msr_platform_info_enabled() fails. Reorder the tests to make test
> pass.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> tools/testing/selftests/kvm/x86_64/platform_info_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/platform_info_test.c b/tools/testing/selftests/kvm/x86_64/platform_info_test.c
> index 40050e44ec0a..f9334bd3cce9 100644
> --- a/tools/testing/selftests/kvm/x86_64/platform_info_test.c
> +++ b/tools/testing/selftests/kvm/x86_64/platform_info_test.c
> @@ -99,8 +99,8 @@ int main(int argc, char *argv[])
> msr_platform_info = vcpu_get_msr(vm, VCPU_ID, MSR_PLATFORM_INFO);
> vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO,
> msr_platform_info | MSR_PLATFORM_INFO_MAX_TURBO_RATIO);
> - test_msr_platform_info_disabled(vm);
> test_msr_platform_info_enabled(vm);
> + test_msr_platform_info_disabled(vm);
> vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, msr_platform_info);
>
> kvm_vm_free(vm);
Ping!
--
Vitaly
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/kvm: make platform_info_test pass on AMD
2019-08-21 16:10 ` Vitaly Kuznetsov
@ 2019-08-21 17:06 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2019-08-21 17:06 UTC (permalink / raw)
To: Vitaly Kuznetsov, kvm; +Cc: linux-kernel, Radim Krčmář
On 21/08/19 18:10, Vitaly Kuznetsov wrote:
> Vitaly Kuznetsov <vkuznets@redhat.com> writes:
>
>> test_msr_platform_info_disabled() generates EXIT_SHUTDOWN but VMCB state
>> is undefined after that so an attempt to launch this guest again from
>> test_msr_platform_info_enabled() fails. Reorder the tests to make test
>> pass.
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>> ---
>> tools/testing/selftests/kvm/x86_64/platform_info_test.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/kvm/x86_64/platform_info_test.c b/tools/testing/selftests/kvm/x86_64/platform_info_test.c
>> index 40050e44ec0a..f9334bd3cce9 100644
>> --- a/tools/testing/selftests/kvm/x86_64/platform_info_test.c
>> +++ b/tools/testing/selftests/kvm/x86_64/platform_info_test.c
>> @@ -99,8 +99,8 @@ int main(int argc, char *argv[])
>> msr_platform_info = vcpu_get_msr(vm, VCPU_ID, MSR_PLATFORM_INFO);
>> vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO,
>> msr_platform_info | MSR_PLATFORM_INFO_MAX_TURBO_RATIO);
>> - test_msr_platform_info_disabled(vm);
>> test_msr_platform_info_enabled(vm);
>> + test_msr_platform_info_disabled(vm);
>> vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, msr_platform_info);
>>
>> kvm_vm_free(vm);
>
> Ping!
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-21 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-10 17:22 [PATCH] selftests/kvm: make platform_info_test pass on AMD Vitaly Kuznetsov
2019-08-21 16:10 ` Vitaly Kuznetsov
2019-08-21 17:06 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).