kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Valeriy Vdovin <valeriy.vdovin@virtuozzo.com>
Cc: linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Shuah Khan <shuah@kernel.org>,
	Aaron Lewis <aaronlewis@google.com>,
	Alexander Graf <graf@amazon.com>,
	Andrew Jones <drjones@redhat.com>,
	Oliver Upton <oupton@google.com>,
	Like Xu <like.xu@linux.intel.com>,
	kvm@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4] KVM: x86: Fix KVM_GET_CPUID2 ioctl to return cpuid entries count
Date: Tue, 4 May 2021 11:15:35 +0300	[thread overview]
Message-ID: <048b3f3a-379d-cff3-20b6-fc74dd12a98f@openvz.org> (raw)
In-Reply-To: <63e54361-0018-ad3b-fb2b-e5dba6a0f221@redhat.com>

On 5/4/21 10:23 AM, Paolo Bonzini wrote:
> On 03/05/21 21:18, Denis V. Lunev wrote:
>> On 5/3/21 5:54 PM, Paolo Bonzini wrote:
>>> On 29/04/21 03:00, Sean Christopherson wrote:
>>>> On Wed, Apr 28, 2021, Valeriy Vdovin wrote:
>>>>> It's very explicit by the code that it was designed to receive some
>>>>> small number of entries to return E2BIG along with the corrected
>>>>> number.
>>>>
>>>> LOL, saying KVM_GET_CPUID2 was "designed" is definitely giving the KVM
>>>> forefathers the benefit of the doubt.
>>>
>>> I was going to make a different joke, i.e. that KVM_GET_CPUID2 was
>>> indeed designed the way Valeriy described, but that design was
>>> forgotten soon after.
>>>
>>> Really, this ioctl has been such a trainwreck that I think the only
>>> good solution here is to drop it.
>>>
>>> Paolo
>>>
>>
>> should we discuss KVM_GET_CPUID3 which will work "normally"?
>
> Is anybody using KVM_GET_CPUID2 at all?
>
> Paolo
>
As far as I understand only some testing within kernel now.
Though we have plans to expose it for QAPI as the series
in QEMU
  [PATCH 1/2] qapi: fix error handling for x-vz-query-cpu-model-cpuid
  [PATCH 2/2] qapi: blacklisted x-vz-query-cpu-model-cpuid in tests
is not coming in a good way.
The idea was to avoid manual code rework in QEMU and
expose collected model at least for debug.

All it all, some control over things set to the kernel as CPU modes
is needed. Without that I am feeling uncomfortable.

Den

  reply	other threads:[~2021-05-04  8:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 17:27 Valeriy Vdovin
2021-04-29  1:00 ` Sean Christopherson
2021-05-03 14:54   ` Paolo Bonzini
2021-05-03 19:18     ` Denis V. Lunev
2021-05-04  7:23       ` Paolo Bonzini
2021-05-04  8:15         ` Denis V. Lunev [this message]
2021-05-04  8:21           ` Paolo Bonzini
2021-05-04  9:26             ` Alexander Graf
2021-05-04  9:50               ` Paolo Bonzini
2021-05-04 16:52               ` Jim Mattson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=048b3f3a-379d-cff3-20b6-fc74dd12a98f@openvz.org \
    --to=den@openvz.org \
    --cc=aaronlewis@google.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=drjones@redhat.com \
    --cc=graf@amazon.com \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=like.xu@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oupton@google.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=valeriy.vdovin@virtuozzo.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH v4] KVM: x86: Fix KVM_GET_CPUID2 ioctl to return cpuid entries count' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).