From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A42C6FD1F for ; Wed, 22 Mar 2023 10:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbjCVKDR (ORCPT ); Wed, 22 Mar 2023 06:03:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbjCVKDN (ORCPT ); Wed, 22 Mar 2023 06:03:13 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DF8F52311A for ; Wed, 22 Mar 2023 03:03:07 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 436CD4B3; Wed, 22 Mar 2023 03:03:51 -0700 (PDT) Received: from [10.57.53.198] (unknown [10.57.53.198]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 67C243F67D; Wed, 22 Mar 2023 03:03:06 -0700 (PDT) Message-ID: <07119162-55c9-cf86-ce55-651496dabb00@arm.com> Date: Wed, 22 Mar 2023 10:02:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 30/30] arm64: Add an efi/run script Content-Language: en-GB To: Andrew Jones Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, alexandru.elisei@arm.com, ricarkol@google.com References: <20230213101759.2577077-1-nikos.nikoleris@arm.com> <20230213101759.2577077-31-nikos.nikoleris@arm.com> <20230321184158.phwwbsk5mv7qwhpa@orel> From: Nikos Nikoleris In-Reply-To: <20230321184158.phwwbsk5mv7qwhpa@orel> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Drew, On 21/03/2023 18:41, Andrew Jones wrote: > On Mon, Feb 13, 2023 at 10:17:59AM +0000, Nikos Nikoleris wrote: >> This change adds a efi/run script inspired by the one in x86. This >> script will setup a folder with the test compiled as an EFI app and a >> startup.nsh script. The script launches QEMU providing an image with >> EDKII and the path to the folder with the test which is executed >> automatically. >> >> For example: >> >> $> ./arm/efi/run ./arm/selftest.efi setup smp=2 mem=256 > > This should be > > ./arm/efi/run ./arm/selftest.efi -append "setup smp=2 mem=256" -smp 2 -m 256 > Indeed, I will update the commit message. > but I can't get any tests to run through ./arm/efi/run. All of them > immediately die with a DABT_EL1. I can get the tests to run (and pass) by > manually booting into UEFI with the FAT partition pointing at the parent > directory > I suppose the DABT_EL1 is happening after the test has started and not while the UEFI interactive shell starts? > $QEMU -nodefaults -machine virt -accel tcg -cpu cortex-a57 \ > -device pci-testdev -display none -serial stdio \ > -bios /usr/share/edk2/aarch64/QEMU_EFI.silent.fd \ > -drive file.dir=efi-tests/,file.driver=vvfat,file.rw=on,format=raw,if=virtio > Do you hit the DABT_EL1 if you let it automatically start using the startup.nsh prepared by the ./arm/efi/run script? Meaning change the above command if you provided -drive file.dir=efi-tests/timer instead: $QEMU -nodefaults -machine virt -accel tcg -cpu cortex-a57 \ -device pci-testdev -display none -serial stdio \ -bios /usr/share/edk2/aarch64/QEMU_EFI.silent.fd \ -drive file.dir=efi tests/timer,file.driver=vvfat,file.rw=on,format=raw,if=virtio Thanks for reviewing this! Nikos > and then, for example for the timer test, doing > > fs0: > cd timer > timer.efi > > but the script never works. > > Thanks, > drew