From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, david@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 5/6] s390x: Prepare for external calls
Date: Mon, 9 Sep 2019 17:47:21 +0200 [thread overview]
Message-ID: <093802cb-519b-144a-0c36-8faa2cbd08d8@redhat.com> (raw)
In-Reply-To: <20190905103951.36522-6-frankja@linux.ibm.com>
On 05/09/2019 12.39, Janosch Frank wrote:
> With SMP we also get new external interrupts like external call and
> emergency call. Let's make them known.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
[...]
> @@ -108,15 +116,23 @@ void handle_pgm_int(void)
>
> void handle_ext_int(void)
> {
> - if (lc->ext_int_code != EXT_IRQ_SERVICE_SIG) {
> + if (!ext_int_expected &&
> + lc->ext_int_code != EXT_IRQ_SERVICE_SIG) {
> report_abort("Unexpected external call interrupt: at %#lx",
> lc->ext_old_psw.addr);
> - } else {
> - lc->ext_old_psw.mask &= ~PSW_MASK_EXT;
> + return;
> + }
> +
> + if (lc->ext_int_code == EXT_IRQ_SERVICE_SIG) {
> lc->sw_int_cr0 &= ~(1UL << 9);
> sclp_handle_ext();
> - lc->ext_int_code = 0;
> }
> + if (lc->ext_int_code != EXT_IRQ_SERVICE_SIG) {
I think you could simplify above line to "else {" ?
With that change:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-09-09 15:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 10:39 [kvm-unit-tests PATCH v2 0/6] s390x: Add multiboot and smp Janosch Frank
2019-09-05 10:39 ` [kvm-unit-tests PATCH v2 1/6] s390x: Use interrupts in SCLP and add locking Janosch Frank
2019-09-09 9:08 ` Thomas Huth
2019-09-10 10:14 ` David Hildenbrand
2019-09-10 11:24 ` David Hildenbrand
2019-09-10 11:25 ` Janosch Frank
2019-09-10 11:30 ` David Hildenbrand
2019-09-05 10:39 ` [kvm-unit-tests PATCH v2 2/6] s390x: Add linemode console Janosch Frank
2019-09-05 10:39 ` [kvm-unit-tests PATCH v2 3/6] s390x: Add linemode buffer to fix newline on every print Janosch Frank
2019-09-09 9:02 ` David Hildenbrand
2019-09-11 7:57 ` David Hildenbrand
2019-09-19 11:07 ` Janosch Frank
2019-09-05 10:39 ` [kvm-unit-tests PATCH v2 4/6] s390x: Add initial smp code Janosch Frank
2019-09-09 15:37 ` Thomas Huth
2019-09-11 8:33 ` Janosch Frank
2019-09-10 12:19 ` Thomas Huth
2019-09-05 10:39 ` [kvm-unit-tests PATCH v2 5/6] s390x: Prepare for external calls Janosch Frank
2019-09-09 15:47 ` Thomas Huth [this message]
2019-09-05 10:39 ` [kvm-unit-tests PATCH v2 6/6] s390x: SMP test Janosch Frank
2019-09-10 9:43 ` Thomas Huth
2019-09-10 11:11 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=093802cb-519b-144a-0c36-8faa2cbd08d8@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).