From: Kirti Wankhede <kwankhede@nvidia.com>
To: Jani Nikula <jani.nikula@intel.com>,
<dri-devel@lists.freedesktop.org>, <linux-fbdev@vger.kernel.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
<intel-gfx@lists.freedesktop.org>, <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 11/12] samples: vfio-mdev: constify fb ops
Date: Tue, 10 Dec 2019 00:13:39 +0530 [thread overview]
Message-ID: <0d5434e0-3d86-bbb8-6377-94e00b4f0d78@nvidia.com> (raw)
In-Reply-To: <87tv694myu.fsf@intel.com>
On 12/9/2019 7:31 PM, Jani Nikula wrote:
> On Tue, 03 Dec 2019, Jani Nikula <jani.nikula@intel.com> wrote:
>> Now that the fbops member of struct fb_info is const, we can start
>> making the ops const as well.
>>
>> v2: fix typo (Christophe de Dinechin)
>>
>> Cc: Kirti Wankhede <kwankhede@nvidia.com>
>> Cc: kvm@vger.kernel.org
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Kirti, may I have your ack to merge this through drm-misc please?
>
> BR,
> Jani.
>
>> ---
>> samples/vfio-mdev/mdpy-fb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c
>> index 2719bb259653..21dbf63d6e41 100644
>> --- a/samples/vfio-mdev/mdpy-fb.c
>> +++ b/samples/vfio-mdev/mdpy-fb.c
>> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info)
>> iounmap(info->screen_base);
>> }
>>
>> -static struct fb_ops mdpy_fb_ops = {
>> +static const struct fb_ops mdpy_fb_ops = {
>> .owner = THIS_MODULE,
>> .fb_destroy = mdpy_fb_destroy,
>> .fb_setcolreg = mdpy_fb_setcolreg,
>
Acked-by : Kirti Wankhede <kwankhede@nvidia.com>
next prev parent reply other threads:[~2019-12-09 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 16:38 [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
2019-12-03 16:38 ` [PATCH v3 11/12] samples: vfio-mdev: constify fb ops Jani Nikula
2019-12-09 14:01 ` Jani Nikula
2019-12-09 18:43 ` Kirti Wankhede [this message]
2019-12-10 6:53 ` Jani Nikula
2019-12-03 16:42 ` [Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d5434e0-3d86-bbb8-6377-94e00b4f0d78@nvidia.com \
--to=kwankhede@nvidia.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).