From: Auger Eric <eric.auger@redhat.com> To: Ricardo Koller <ricarkol@google.com>, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu Cc: pbonzini@redhat.com, maz@kernel.org, drjones@redhat.com, alexandru.elisei@arm.com Subject: Re: [PATCH v2 1/5] KVM: selftests: Rename vm_handle_exception Date: Thu, 6 May 2021 14:27:42 +0200 [thread overview] Message-ID: <0e0e8341-9c4d-13e8-f037-e84f0ee291dd@redhat.com> (raw) In-Reply-To: <20210430232408.2707420-2-ricarkol@google.com> Hi Ricardo, On 5/1/21 1:24 AM, Ricardo Koller wrote: > Rename the vm_handle_exception function to a name that indicates more > clearly that it installs something: vm_install_vector_handler. > > Suggested-by: Marc Zyngier <maz@kernel.org> > Suggested-by: Andrew Jones <drjones@redhat.com> > Signed-off-by: Ricardo Koller <ricarkol@google.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks Eric > --- > tools/testing/selftests/kvm/include/x86_64/processor.h | 2 +- > tools/testing/selftests/kvm/lib/x86_64/processor.c | 4 ++-- > tools/testing/selftests/kvm/x86_64/kvm_pv_test.c | 2 +- > .../selftests/kvm/x86_64/userspace_msr_exit_test.c | 8 ++++---- > tools/testing/selftests/kvm/x86_64/xapic_ipi_test.c | 2 +- > 5 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h > index 0b30b4e15c38..12889d3e8948 100644 > --- a/tools/testing/selftests/kvm/include/x86_64/processor.h > +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h > @@ -391,7 +391,7 @@ struct ex_regs { > > void vm_init_descriptor_tables(struct kvm_vm *vm); > void vcpu_init_descriptor_tables(struct kvm_vm *vm, uint32_t vcpuid); > -void vm_handle_exception(struct kvm_vm *vm, int vector, > +void vm_install_vector_handler(struct kvm_vm *vm, int vector, > void (*handler)(struct ex_regs *)); > > /* > diff --git a/tools/testing/selftests/kvm/lib/x86_64/processor.c b/tools/testing/selftests/kvm/lib/x86_64/processor.c > index a8906e60a108..e156061263a6 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/processor.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/processor.c > @@ -1250,8 +1250,8 @@ void vcpu_init_descriptor_tables(struct kvm_vm *vm, uint32_t vcpuid) > *(vm_vaddr_t *)addr_gva2hva(vm, (vm_vaddr_t)(&exception_handlers)) = vm->handlers; > } > > -void vm_handle_exception(struct kvm_vm *vm, int vector, > - void (*handler)(struct ex_regs *)) > +void vm_install_vector_handler(struct kvm_vm *vm, int vector, > + void (*handler)(struct ex_regs *)) > { > vm_vaddr_t *handlers = (vm_vaddr_t *)addr_gva2hva(vm, vm->handlers); > > diff --git a/tools/testing/selftests/kvm/x86_64/kvm_pv_test.c b/tools/testing/selftests/kvm/x86_64/kvm_pv_test.c > index 732b244d6956..5ae5f748723a 100644 > --- a/tools/testing/selftests/kvm/x86_64/kvm_pv_test.c > +++ b/tools/testing/selftests/kvm/x86_64/kvm_pv_test.c > @@ -227,7 +227,7 @@ int main(void) > > vm_init_descriptor_tables(vm); > vcpu_init_descriptor_tables(vm, VCPU_ID); > - vm_handle_exception(vm, GP_VECTOR, guest_gp_handler); > + vm_install_vector_handler(vm, GP_VECTOR, guest_gp_handler); > > enter_guest(vm); > kvm_vm_free(vm); > diff --git a/tools/testing/selftests/kvm/x86_64/userspace_msr_exit_test.c b/tools/testing/selftests/kvm/x86_64/userspace_msr_exit_test.c > index 72c0d0797522..20c373e2d329 100644 > --- a/tools/testing/selftests/kvm/x86_64/userspace_msr_exit_test.c > +++ b/tools/testing/selftests/kvm/x86_64/userspace_msr_exit_test.c > @@ -574,7 +574,7 @@ static void test_msr_filter_allow(void) { > vm_init_descriptor_tables(vm); > vcpu_init_descriptor_tables(vm, VCPU_ID); > > - vm_handle_exception(vm, GP_VECTOR, guest_gp_handler); > + vm_install_vector_handler(vm, GP_VECTOR, guest_gp_handler); > > /* Process guest code userspace exits. */ > run_guest_then_process_rdmsr(vm, MSR_IA32_XSS); > @@ -588,12 +588,12 @@ static void test_msr_filter_allow(void) { > run_guest_then_process_wrmsr(vm, MSR_NON_EXISTENT); > run_guest_then_process_rdmsr(vm, MSR_NON_EXISTENT); > > - vm_handle_exception(vm, UD_VECTOR, guest_ud_handler); > + vm_install_vector_handler(vm, UD_VECTOR, guest_ud_handler); > run_guest(vm); > - vm_handle_exception(vm, UD_VECTOR, NULL); > + vm_install_vector_handler(vm, UD_VECTOR, NULL); > > if (process_ucall(vm) != UCALL_DONE) { > - vm_handle_exception(vm, GP_VECTOR, guest_fep_gp_handler); > + vm_install_vector_handler(vm, GP_VECTOR, guest_fep_gp_handler); > > /* Process emulated rdmsr and wrmsr instructions. */ > run_guest_then_process_rdmsr(vm, MSR_IA32_XSS); > diff --git a/tools/testing/selftests/kvm/x86_64/xapic_ipi_test.c b/tools/testing/selftests/kvm/x86_64/xapic_ipi_test.c > index 2f964cdc273c..ded70ff465d5 100644 > --- a/tools/testing/selftests/kvm/x86_64/xapic_ipi_test.c > +++ b/tools/testing/selftests/kvm/x86_64/xapic_ipi_test.c > @@ -462,7 +462,7 @@ int main(int argc, char *argv[]) > > vm_init_descriptor_tables(vm); > vcpu_init_descriptor_tables(vm, HALTER_VCPU_ID); > - vm_handle_exception(vm, IPI_VECTOR, guest_ipi_handler); > + vm_install_vector_handler(vm, IPI_VECTOR, guest_ipi_handler); > > virt_pg_map(vm, APIC_DEFAULT_GPA, APIC_DEFAULT_GPA, 0); > >
next prev parent reply other threads:[~2021-05-06 12:27 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-30 23:24 [PATCH v2 0/5] KVM: selftests: arm64 exception handling and debug test Ricardo Koller 2021-04-30 23:24 ` [PATCH v2 1/5] KVM: selftests: Rename vm_handle_exception Ricardo Koller 2021-05-03 11:02 ` Andrew Jones 2021-05-06 12:27 ` Auger Eric [this message] 2021-04-30 23:24 ` [PATCH v2 2/5] KVM: selftests: Introduce UCALL_UNHANDLED for unhandled vector reporting Ricardo Koller 2021-05-03 11:09 ` Andrew Jones 2021-05-06 12:27 ` Auger Eric 2021-04-30 23:24 ` [PATCH v2 3/5] KVM: selftests: Move GUEST_ASSERT_EQ to utils header Ricardo Koller 2021-05-03 11:31 ` Andrew Jones 2021-04-30 23:24 ` [PATCH v2 4/5] KVM: selftests: Add exception handling support for aarch64 Ricardo Koller 2021-05-03 10:32 ` Marc Zyngier 2021-05-03 19:12 ` Ricardo Koller 2021-05-06 12:30 ` Auger Eric 2021-05-06 19:14 ` Ricardo Koller 2021-05-07 14:08 ` Auger Eric 2021-05-07 17:54 ` Ricardo Koller 2021-05-12 7:27 ` Ricardo Koller 2021-05-12 8:19 ` Auger Eric 2021-05-12 8:33 ` Marc Zyngier 2021-05-12 8:52 ` Auger Eric 2021-05-12 16:06 ` Ricardo Koller 2021-05-12 12:59 ` Zenghui Yu 2021-05-12 13:43 ` Marc Zyngier 2021-05-12 16:03 ` Ricardo Koller 2021-05-12 16:18 ` Marc Zyngier 2021-05-12 21:39 ` Ricardo Koller 2021-05-07 14:31 ` Marc Zyngier 2021-05-07 18:02 ` Ricardo Koller 2021-05-03 12:39 ` Andrew Jones 2021-04-30 23:24 ` [PATCH v2 5/5] KVM: selftests: Add aarch64/debug-exceptions test Ricardo Koller 2021-05-03 12:49 ` Andrew Jones 2021-05-24 12:14 ` [PATCH v2 0/5] KVM: selftests: arm64 exception handling and debug test Paolo Bonzini 2021-05-24 12:59 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0e0e8341-9c4d-13e8-f037-e84f0ee291dd@redhat.com \ --to=eric.auger@redhat.com \ --cc=alexandru.elisei@arm.com \ --cc=drjones@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=maz@kernel.org \ --cc=pbonzini@redhat.com \ --cc=ricarkol@google.com \ --subject='Re: [PATCH v2 1/5] KVM: selftests: Rename vm_handle_exception' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).