From: Paolo Bonzini <pbonzini@redhat.com>
To: "Xiaoyao Li" <xiaoyao.li@intel.com>, "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Sean Christopherson <sean.j.christopherson@intel.com>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] doc: kvm: Fix return description of KVM_SET_MSRS
Date: Tue, 10 Sep 2019 19:14:07 +0200 [thread overview]
Message-ID: <0f4d8b77-2c42-f5b5-1cba-9cc26c5fd935@redhat.com> (raw)
In-Reply-To: <20190905005737.131067-1-xiaoyao.li@intel.com>
On 05/09/19 02:57, Xiaoyao Li wrote:
> Userspace can use ioctl KVM_SET_MSRS to update a set of MSRs of guest.
> This ioctl set specified MSRs one by one. If it fails to set an MSR,
> e.g., due to setting reserved bits, the MSR is not supported/emulated by
> KVM, etc..., it stops processing the MSR list and returns the number of
> MSRs have been set successfully.
>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Queued, thanks.
Paolo
> ---
> v3:
> refine the description based on Sean's comment.
>
> v2:
> elaborate the changelog and description of ioctl KVM_SET_MSRS based on
> Sean's comments.
> ---
> Documentation/virt/kvm/api.txt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/virt/kvm/api.txt b/Documentation/virt/kvm/api.txt
> index 2d067767b617..24541e52e96e 100644
> --- a/Documentation/virt/kvm/api.txt
> +++ b/Documentation/virt/kvm/api.txt
> @@ -586,7 +586,7 @@ Capability: basic
> Architectures: x86
> Type: vcpu ioctl
> Parameters: struct kvm_msrs (in)
> -Returns: 0 on success, -1 on error
> +Returns: number of msrs successfully set (see below), -1 on error
>
> Writes model-specific registers to the vcpu. See KVM_GET_MSRS for the
> data structures.
> @@ -595,6 +595,11 @@ Application code should set the 'nmsrs' member (which indicates the
> size of the entries array), and the 'index' and 'data' members of each
> array entry.
>
> +It tries to set the MSRs in array entries[] one by one. If setting an MSR
> +fails, e.g., due to setting reserved bits, the MSR isn't supported/emulated
> +by KVM, etc..., it stops processing the MSR list and returns the number of
> +MSRs that have been set successfully.
> +
>
> 4.20 KVM_SET_CPUID
>
>
prev parent reply other threads:[~2019-09-10 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 0:57 [PATCH v3] doc: kvm: Fix return description of KVM_SET_MSRS Xiaoyao Li
2019-09-10 17:14 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f4d8b77-2c42-f5b5-1cba-9cc26c5fd935@redhat.com \
--to=pbonzini@redhat.com \
--cc=corbet@lwn.net \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).