From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 026BAC433B4 for ; Mon, 3 May 2021 15:26:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB18761278 for ; Mon, 3 May 2021 15:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230414AbhECP1P (ORCPT ); Mon, 3 May 2021 11:27:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35352 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230412AbhECP1B (ORCPT ); Mon, 3 May 2021 11:27:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620055567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dNAN0Sy84V91r8TIcd0SMOVKRWb8qpjeLtBN5c2xdHU=; b=XSrdLMot42NQDku6wzQXkU6tpF2DK4uCWD4OgJAmLwMB6e/NhGJg00gx0aXHtcXw5M8eda vSZEasUZn5YHxOmoHQjOnZK52Op4JoFPhCqIjVBL3KM1r9T4Rx2IFTkr1sOE5elW452ssl ydNsOZ7Esxx0+bQV15I6rUYze1yL4c8= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-352-N8nplHQxM8i2JJtWX2QstQ-1; Mon, 03 May 2021 11:26:04 -0400 X-MC-Unique: N8nplHQxM8i2JJtWX2QstQ-1 Received: by mail-ej1-f71.google.com with SMTP id x21-20020a1709064bd5b029037c44cb861cso2202632ejv.4 for ; Mon, 03 May 2021 08:26:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dNAN0Sy84V91r8TIcd0SMOVKRWb8qpjeLtBN5c2xdHU=; b=MQcrnpWd94rn7wrjoADSbJiCfZvEZOJ5GiSru6LvGk25kTDiqiOmnUCth+tnYyS0dK Liz6ZEpXRZ/yhfrBJB5U3oH1c9ALeQQBamjOkBmmpnNGTfPAFSW40W3Kfb3/pbQ9f0F2 j1ojpwDT8nR3nflbaAjIaggeSBF6zDnCtxEx4Igtl+/wOYBTVrczk4geUFjiakhddJiA hREnw/l1LTk/qfMpcyuB2fKbGKyvYXtkBxoO+B+8pWvvRzrlYEzoXDr6AbzJXW0AYj/i R+OmZ+yp433Toi66P1F6A5f+sfUzJnO0ZTeQLlbyRY2EGP8qsLO/nU11LapW6OlmmV4o Tvjw== X-Gm-Message-State: AOAM530iA89zK2qjZ0cwiSBVQgfCUfDpY5y9FlxgzXnpT9KKetMGShaD BxcOP9IButDE9Vt5NO/0Cd7xWE8eB67GUYO59HyA3Bna71Mvmyy6lJcmdqvH+2QmNT+t8uaurJe Kpgb3zWY+STMM X-Received: by 2002:a17:906:2616:: with SMTP id h22mr17684809ejc.126.1620055562835; Mon, 03 May 2021 08:26:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2AWMVkxk9uopT3QTgTPSyNzTAgr3WMD7QdCwySYsZDlZysqavhUHY8k5d/fPnCqHgzkClMg== X-Received: by 2002:a17:906:2616:: with SMTP id h22mr17684792ejc.126.1620055562674; Mon, 03 May 2021 08:26:02 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id me3sm17378ejb.49.2021.05.03.08.26.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 May 2021 08:26:02 -0700 (PDT) Subject: Re: [PATCH 0/5] x86/kvm: Refactor KVM PV features teardown and fix restore from hibernation To: Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , x86@kernel.org, Lenny Szubowicz , Mohamed Aboubakr , Xiaoyi Chen , linux-kernel@vger.kernel.org References: <20210414123544.1060604-1-vkuznets@redhat.com> From: Paolo Bonzini Message-ID: <1134cd5c-29f4-c149-4380-1f6bff193398@redhat.com> Date: Mon, 3 May 2021 17:26:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210414123544.1060604-1-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 14/04/21 14:35, Vitaly Kuznetsov wrote: > This series is a successor of Lenny's "[PATCH] x86/kvmclock: Stop kvmclocks > for hibernate restore". While reviewing his patch I realized that PV > features teardown we have is a bit messy: it is scattered across kvm.c > and kvmclock.c and not all features are being shutdown an all paths. > This series unifies all teardown paths in kvm.c and makes sure all > features are disabled when needed. > > Vitaly Kuznetsov (5): > x86/kvm: Fix pr_info() for async PF setup/teardown > x86/kvm: Teardown PV features on boot CPU as well > x86/kvm: Disable kvmclock on all CPUs on shutdown > x86/kvm: Disable all PV features on crash > x86/kvm: Unify kvm_pv_guest_cpu_reboot() with kvm_guest_cpu_offline() > > arch/x86/include/asm/kvm_para.h | 10 +-- > arch/x86/kernel/kvm.c | 113 +++++++++++++++++++++----------- > arch/x86/kernel/kvmclock.c | 26 +------- > 3 files changed, 78 insertions(+), 71 deletions(-) > Queuing this patch, thanks. If the Amazon folks want to provide their Tested-by (since they looked at it before and tested Lenny's first attempt at using syscore_ops), they're still in time! Paolo