From: Paolo Bonzini <pbonzini@redhat.com>
To: Bill Wendling <morbo@google.com>,
kvm@vger.kernel.org, jmattson@google.com
Cc: thuth@redhat.com, alexandru.elisei@arm.com
Subject: Re: [kvm-unit-tests PATCH v3 1/2] x86: realmode: save and restore %es
Date: Mon, 4 Nov 2019 13:08:00 +0100 [thread overview]
Message-ID: <119b3e09-1907-5c7f-7c47-753ce7effe23@redhat.com> (raw)
In-Reply-To: <20191101203353.150049-2-morbo@google.com>
On 01/11/19 21:33, Bill Wendling wrote:
> Some of the code test sequences (e.g. push_es) clobber ES. That causes
> trouble for future rep string instructions. So save and restore ES
> around the test code sequence in exec_in_big_real_mode.
You mean pop_es. Applied with that change.
Paolo
next prev parent reply other threads:[~2019-11-04 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 20:33 [kvm-unit-tests PATCH v3 0/2] Save/Restore clobbered register and struct initialization Bill Wendling
2019-11-01 20:33 ` [kvm-unit-tests PATCH v3 1/2] x86: realmode: save and restore %es Bill Wendling
2019-11-04 12:08 ` Paolo Bonzini [this message]
2019-11-05 18:07 ` Jim Mattson
2019-11-05 22:26 ` Paolo Bonzini
2019-11-01 20:33 ` [kvm-unit-tests PATCH v3 2/2] x86: realmode: initialize inregs with a stack Bill Wendling
2019-11-04 12:09 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=119b3e09-1907-5c7f-7c47-753ce7effe23@redhat.com \
--to=pbonzini@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=morbo@google.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).