From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEA3AC43603 for ; Fri, 6 Dec 2019 10:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF20B24676 for ; Fri, 6 Dec 2019 10:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726171AbfLFKK6 (ORCPT ); Fri, 6 Dec 2019 05:10:58 -0500 Received: from foss.arm.com ([217.140.110.172]:38228 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726084AbfLFKK5 (ORCPT ); Fri, 6 Dec 2019 05:10:57 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E175DDA7; Fri, 6 Dec 2019 02:10:56 -0800 (PST) Received: from [10.1.194.43] (e112269-lin.cambridge.arm.com [10.1.194.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EA3713F718; Fri, 6 Dec 2019 02:10:54 -0800 (PST) Subject: Re: [PATCH] KVM: arm: get rid of unused arg in cpu_init_hyp_mode() To: linmiaohe , "maz@kernel.org" , "james.morse@arm.com" , "julien.thierry.kdev@gmail.com" , "suzuki.poulose@arm.com" , "christoffer.dall@arm.com" , "catalin.marinas@arm.com" , "eric.auger@redhat.com" , "gregkh@linuxfoundation.org" , "will@kernel.org" , "andre.przywara@arm.com" , "tglx@linutronix.de" Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" References: <8efe4ab7f8c44c48a70378247c511edc@huawei.com> From: Steven Price Message-ID: <11f06523-54ce-7025-a6ba-58c29769da60@arm.com> Date: Fri, 6 Dec 2019 10:10:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <8efe4ab7f8c44c48a70378247c511edc@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 30/11/2019 07:20, linmiaohe wrote: >> From: Miaohe Lin >> >> As arg dummy is not really needed, there's no need to pass NULL when calling cpu_init_hyp_mode(). So clean it up. It looks like the requirement for this dummy arg was removed in 67f691976662 ("arm64: kvm: allows kvm cpu hotplug"). FWIW: Reviewed-by: Steven Price >> Signed-off-by: Miaohe Lin >> --- >> virt/kvm/arm/arm.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 86c6aa1cb58e..a5470f1b1a19 100644 >> --- a/virt/kvm/arm/arm.c >> +++ b/virt/kvm/arm/arm.c >> @@ -1315,7 +1315,7 @@ long kvm_arch_vm_ioctl(struct file *filp, >> } >> } >> >> -static void cpu_init_hyp_mode(void *dummy) >> +static void cpu_init_hyp_mode(void) >> { >> phys_addr_t pgd_ptr; >> unsigned long hyp_stack_ptr; >> @@ -1349,7 +1349,7 @@ static void cpu_hyp_reinit(void) >> if (is_kernel_in_hyp_mode()) >> kvm_timer_init_vhe(); >> else >> - cpu_init_hyp_mode(NULL); >> + cpu_init_hyp_mode(); >> >> kvm_arm_init_debug(); >> > friendly ping ... >