From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Zupka Subject: Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test Date: Wed, 16 Sep 2009 09:09:43 -0400 (EDT) Message-ID: <1205086068.232401253106583969.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> References: <83259492.232221253106465155.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, autotest@test.kernel.org, Lukas Doktor To: dlaor@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47603 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758920AbZIPNJl (ORCPT ); Wed, 16 Sep 2009 09:09:41 -0400 In-Reply-To: <83259492.232221253106465155.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: ----- "Dor Laor" wrote: > On 09/15/2009 09:58 PM, Jiri Zupka wrote: > >> After a quick review I have the following questions: > >> 1. Why did you implement the guest tool in 'c' and not in python? > >> Python is much simpler and you can share some code with the > server. > >> This 'test protocol' would also be easier to understand this > way. > > > > We need speed and the precise control of allocate memory in pages. > > > >> 2. IMHO there is no need to use select, you can do blocking read. > > > > We replace socket communication by interactive program communication > via ssh/telnet > > > >> 3. Also you can use plain malloc without the more complex ( a bit) > mmap. > > > > We need address exactly the memory pages. We can't allow shift of > the data in memory. > > You can use the tmpfs+dd idea instead of the specific program as I > detailed before. Maybe some other binary can be used. My intention is > to > simplify the test/environment as much as possible. > We need compatibility with others system, like Windows etc.. We want to add support for others system in next version > > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html