From: Alex Williamson <alex.williamson@hp.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>, kvm <kvm@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/4] virtio_net: Allow setting the MAC address of the NIC
Date: Wed, 14 Jan 2009 08:40:12 -0700 [thread overview]
Message-ID: <1231947612.7109.267.camel@lappy> (raw)
In-Reply-To: <1231928106.4944.289.camel@localhost.localdomain>
On Wed, 2009-01-14 at 10:15 +0000, Mark McLoughlin wrote:
> On Tue, 2009-01-13 at 14:23 -0700, Alex Williamson wrote:
>
> Commit log explaining why we need this.
Sorry, my commit logs are pretty weak across the board. I'll update
them all.
> > + } else {
> > random_ether_addr(dev->dev_addr);
> > + vdev->config->set(vdev, offsetof(struct virtio_net_config, mac),
> > + dev->dev_addr, dev->addr_len);
> > + }
>
> Please make sure you test this with a host which doesn't set a default
> mac address, otherwise it's "untested buggy code" :-)
Good idea, I'll hack the backend to not advertise that feature and make
sure this code gets exercised a least once. Thanks,
Alex
--
Alex Williamson HP Open Source & Linux Org.
prev parent reply other threads:[~2009-01-14 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 21:23 [PATCH 1/4] virtio_net: Allow setting the MAC address of the NIC Alex Williamson
2009-01-14 10:15 ` Mark McLoughlin
2009-01-14 15:40 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231947612.7109.267.camel@lappy \
--to=alex.williamson@hp.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).