From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
Collin Walling <walling@linux.ibm.com>
Cc: kvm@vger.kernel.org, gor@linux.ibm.com, hca@linux.ibm.com,
imbrenda@linux.ibm.com, david@redhat.com, frankja@linux.ibm.com
Subject: Re: [PATCH] s390/kvm: remove diag318 reset code
Date: Tue, 10 Nov 2020 13:41:17 +0100 [thread overview]
Message-ID: <128492b1-2d2d-babe-3c27-10f3d1f493e9@de.ibm.com> (raw)
In-Reply-To: <20201110114339.3515ec7a.cohuck@redhat.com>
On 10.11.20 11:43, Cornelia Huck wrote:
> On Wed, 4 Nov 2020 13:10:32 -0500
> Collin Walling <walling@linux.ibm.com> wrote:
>
>> The diag318 data must be set to 0 by VM-wide reset events
>> triggered by diag308. As such, KVM should not handle
>> resetting this data via the VCPU ioctls.
>>
>> Fixes: 23a60f834406 (s390/kvm: diagnose 0x318 sync and reset)
>
> Should be
>
> Fixes: 23a60f834406 ("s390/kvm: diagnose 0x318 sync and reset")
yes.
>
>> Signed-off-by: Collin Walling <walling@linux.ibm.com>
>> ---
>> arch/s390/kvm/kvm-s390.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 6b74b92c1a58..f9e118a0e113 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -3564,7 +3564,6 @@ static void kvm_arch_vcpu_ioctl_initial_reset(struct kvm_vcpu *vcpu)
>> vcpu->arch.sie_block->pp = 0;
>> vcpu->arch.sie_block->fpf &= ~FPF_BPBC;
>> vcpu->arch.sie_block->todpr = 0;
>> - vcpu->arch.sie_block->cpnc = 0;
>> }
>> }
>>
>> @@ -3582,7 +3581,6 @@ static void kvm_arch_vcpu_ioctl_clear_reset(struct kvm_vcpu *vcpu)
>>
>> regs->etoken = 0;
>> regs->etoken_extension = 0;
>> - regs->diag318 = 0;
>> }
>>
>> int kvm_arch_vcpu_ioctl_set_regs(struct kvm_vcpu *vcpu, struct kvm_regs *regs)
>
> I assume that we rely on the QEMU patch to get a completely working
> setup?
Yes, but this fix is correct in itself and needed anyway.
next prev parent reply other threads:[~2020-11-10 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 18:10 [PATCH] s390/kvm: remove diag318 reset code Collin Walling
2020-11-04 18:29 ` Christian Borntraeger
2020-11-09 7:50 ` Janosch Frank
2020-11-10 10:43 ` Cornelia Huck
2020-11-10 12:41 ` Christian Borntraeger [this message]
2020-11-10 12:55 ` Cornelia Huck
2020-11-10 13:09 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=128492b1-2d2d-babe-3c27-10f3d1f493e9@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).