From: Nikos Nikoleris <nikos.nikoleris@arm.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Cc: alexandru.elisei@arm.com, andre.przywara@arm.com, eric.auger@redhat.com
Subject: Re: [PATCH kvm-unit-tests 2/8] arm/arm64: Move setup_vm into setup
Date: Fri, 9 Apr 2021 18:24:00 +0100 [thread overview]
Message-ID: <13d56963-63f0-be3d-d68a-5581f1d558b7@arm.com> (raw)
In-Reply-To: <20210407185918.371983-3-drjones@redhat.com>
On 07/04/2021 19:59, Andrew Jones wrote:
> Consolidate our setup calls to reduce the amount we need to do from
> init::start. Also remove a couple of pointless comments from setup().
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
No need for this to be in assembly.
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Thanks,
Nikos
> ---
> arm/cstart.S | 6 ------
> arm/cstart64.S | 5 -----
> lib/arm/setup.c | 7 +++++--
> 3 files changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/arm/cstart.S b/arm/cstart.S
> index 653ab1e8a141..731f841695ce 100644
> --- a/arm/cstart.S
> +++ b/arm/cstart.S
> @@ -81,12 +81,7 @@ start:
> /* complete setup */
> pop {r0-r1}
> bl setup
> - bl get_mmu_off
> - cmp r0, #0
> - bne 1f
> - bl setup_vm
>
> -1:
> /* run the test */
> ldr r0, =__argc
> ldr r0, [r0]
> @@ -108,7 +103,6 @@ enable_vfp:
> vmsr fpexc, r0
> mov pc, lr
>
> -.global get_mmu_off
> get_mmu_off:
> ldr r0, =auxinfo
> ldr r0, [r0, #4]
> diff --git a/arm/cstart64.S b/arm/cstart64.S
> index d39cf4dfb99c..add60a2b4e74 100644
> --- a/arm/cstart64.S
> +++ b/arm/cstart64.S
> @@ -95,11 +95,7 @@ start:
> /* complete setup */
> mov x0, x4 // restore the addr of the dtb
> bl setup
> - bl get_mmu_off
> - cbnz x0, 1f
> - bl setup_vm
>
> -1:
> /* run the test */
> adrp x0, __argc
> ldr w0, [x0, :lo12:__argc]
> @@ -113,7 +109,6 @@ start:
>
> .text
>
> -.globl get_mmu_off
> get_mmu_off:
> adrp x0, auxinfo
> ldr x0, [x0, :lo12:auxinfo + 8]
> diff --git a/lib/arm/setup.c b/lib/arm/setup.c
> index 751ba980000a..9c16f6004e9f 100644
> --- a/lib/arm/setup.c
> +++ b/lib/arm/setup.c
> @@ -16,6 +16,8 @@
> #include <alloc.h>
> #include <alloc_phys.h>
> #include <alloc_page.h>
> +#include <vmalloc.h>
> +#include <auxinfo.h>
> #include <argv.h>
> #include <asm/thread_info.h>
> #include <asm/setup.h>
> @@ -233,7 +235,6 @@ void setup(const void *fdt)
> freemem += initrd_size;
> }
>
> - /* call init functions */
> mem_init(PAGE_ALIGN((unsigned long)freemem));
> cpu_init();
>
> @@ -243,7 +244,6 @@ void setup(const void *fdt)
> /* mem_init must be called before io_init */
> io_init();
>
> - /* finish setup */
> timer_save_state();
>
> ret = dt_get_bootargs(&bootargs);
> @@ -256,4 +256,7 @@ void setup(const void *fdt)
> memcpy(env, initrd, initrd_size);
> setup_env(env, initrd_size);
> }
> +
> + if (!(auxinfo.flags & AUXINFO_MMU_OFF))
> + setup_vm();
> }
>
next prev parent reply other threads:[~2021-04-09 17:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 18:59 [PATCH kvm-unit-tests 0/8] arm/arm64: Prepare for target-efi Andrew Jones
2021-04-07 18:59 ` [PATCH kvm-unit-tests 1/8] arm/arm64: Reorganize cstart assembler Andrew Jones
2021-04-09 17:18 ` Nikos Nikoleris
2021-04-09 17:28 ` Andrew Jones
2021-04-13 16:34 ` Alexandru Elisei
2021-04-14 8:59 ` Andrew Jones
2021-04-14 15:15 ` Alexandru Elisei
2021-04-15 13:03 ` Andrew Jones
2021-04-07 18:59 ` [PATCH kvm-unit-tests 2/8] arm/arm64: Move setup_vm into setup Andrew Jones
2021-04-09 17:24 ` Nikos Nikoleris [this message]
2021-04-14 15:19 ` Alexandru Elisei
2021-04-07 18:59 ` [PATCH kvm-unit-tests 3/8] pci-testdev: ioremap regions Andrew Jones
2021-04-13 14:12 ` Nikos Nikoleris
2021-04-07 18:59 ` [PATCH kvm-unit-tests 4/8] arm/arm64: mmu: Stop mapping an assumed IO region Andrew Jones
2021-04-13 14:06 ` Nikos Nikoleris
2021-04-14 15:42 ` Alexandru Elisei
2021-04-15 13:09 ` Andrew Jones
2021-04-07 18:59 ` [PATCH kvm-unit-tests 5/8] arm/arm64: mmu: Remove memory layout assumptions Andrew Jones
2021-04-13 14:27 ` Nikos Nikoleris
2021-04-15 15:48 ` Alexandru Elisei
2021-04-15 17:11 ` Andrew Jones
2021-04-19 15:09 ` Alexandru Elisei
2021-04-07 18:59 ` [PATCH kvm-unit-tests 6/8] arm/arm64: setup: Consolidate " Andrew Jones
2021-04-13 16:41 ` Nikos Nikoleris
2021-04-14 9:03 ` Andrew Jones
2021-04-15 16:59 ` Alexandru Elisei
2021-04-15 17:25 ` Andrew Jones
2021-04-19 15:56 ` Alexandru Elisei
2021-04-19 15:59 ` Alexandru Elisei
2021-04-19 17:53 ` Andrew Jones
2021-04-07 18:59 ` [PATCH kvm-unit-tests 7/8] chr-testdev: Silently fail init Andrew Jones
2021-04-13 16:42 ` Nikos Nikoleris
2021-04-15 17:03 ` Alexandru Elisei
2021-04-07 18:59 ` [PATCH kvm-unit-tests 8/8] arm/arm64: psci: don't assume method is hvc Andrew Jones
2021-04-09 17:46 ` Nikos Nikoleris
2021-04-14 9:06 ` Andrew Jones
2021-04-19 16:33 ` Alexandru Elisei
2021-04-19 18:13 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13d56963-63f0-be3d-d68a-5581f1d558b7@arm.com \
--to=nikos.nikoleris@arm.com \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).