kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 4/5] s390x: STSI tests
Date: Tue, 3 Sep 2019 12:53:51 +0200	[thread overview]
Message-ID: <1416cb79-09b6-8067-041f-16522860cd88@linux.ibm.com> (raw)
In-Reply-To: <72cc113e-63a2-d389-d1fb-b0b9e84fc863@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1962 bytes --]

On 8/30/19 2:07 PM, David Hildenbrand wrote:
> On 26.08.19 18:35, Janosch Frank wrote:
>> For now let's concentrate on the error conditions.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
[...]
>> +static inline unsigned long stsi_get_fc(void *addr)
>> +{
>> +	register unsigned long r0 asm("0") = 0;
>> +	register unsigned long r1 asm("1") = 0;
>> +	int cc;
>> +
>> +	asm volatile("stsi	0(%3)\n"
>> +		     "ipm	%[cc]\n"
>> +		     "srl	%[cc],28\n"
>> +		     : "+d" (r0), [cc] "=d" (cc)
>> +		     : "d" (r1), "a" (addr)
> 
> maybe [addr], so you can avoid the %3 above

Sure, maybe Thomas can also fix that on picking for the previous patch?

> 
>> +		     : "cc", "memory");
>> +	assert(!cc);
>> +	return r0 >> 28;
> 
> I think I'd prefer "get_configuration_level()" and move it to an header
> - because the fc actually allows more values (0, 15 ...) - however the
> level can be used as an fc.

The rename works for me, but that's currently used only once, so why
should it go to a header file?

I though about starting lib/s390x/asm/misc-instr.h if we have enough (>=
2) instruction definitions which are shared.

> 
> 
>> +}
>> +
>> +static void test_fc(void)
>> +{
>> +	report("invalid fc",  stsi(pagebuf, 7, 0, 0) == 3);
>> +	report("query fc >= 2",  stsi_get_fc(pagebuf) >= 2);
>> +}
>> +
>> +int main(void)
>> +{
>> +	report_prefix_push("stsi");
>> +	test_priv();
>> +	test_specs();
>> +	test_fc();
>> +	return report_summary();
>> +}
>> diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
>> index 9dd288a..cc79a4e 100644
>> --- a/s390x/unittests.cfg
>> +++ b/s390x/unittests.cfg
>> @@ -68,3 +68,6 @@ file = cpumodel.elf
>>  [diag288]
>>  file = diag288.elf
>>  extra_params=-device diag288,id=watchdog0 --watchdog-action inject-nmi
>> +
>> +[stsi]
>> +file = stsi.elf
>>
> 
> Apart from that
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-09-03 10:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 16:34 [kvm-unit-tests PATCH v3 0/5] s390x: More emulation tests Janosch Frank
2019-08-26 16:34 ` [kvm-unit-tests PATCH v3 1/5] s390x: Support PSW restart boot Janosch Frank
2019-08-26 16:34 ` [kvm-unit-tests PATCH v3 2/5] s390x: Diag288 test Janosch Frank
2019-08-26 17:14   ` Thomas Huth
2019-08-27  7:46     ` [kvm-unit-tests PATCH] " Janosch Frank
2019-08-27 10:29       ` Thomas Huth
2019-08-26 16:35 ` [kvm-unit-tests PATCH v3 3/5] s390x: Move stsi to library Janosch Frank
2019-08-26 16:35 ` [kvm-unit-tests PATCH v3 4/5] s390x: STSI tests Janosch Frank
2019-08-30 12:07   ` David Hildenbrand
2019-09-03 10:53     ` Janosch Frank [this message]
2019-09-03 10:57       ` David Hildenbrand
2019-09-03 10:58       ` Thomas Huth
2019-08-26 16:35 ` [kvm-unit-tests PATCH v3 5/5] s390x: Add diag308 subcode 0 testing Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416cb79-09b6-8067-041f-16522860cd88@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).