From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26FCEC468BD for ; Fri, 7 Jun 2019 09:54:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0773020B7C for ; Fri, 7 Jun 2019 09:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727111AbfFGJy1 (ORCPT ); Fri, 7 Jun 2019 05:54:27 -0400 Received: from mga01.intel.com ([192.55.52.88]:34433 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726844AbfFGJy1 (ORCPT ); Fri, 7 Jun 2019 05:54:27 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2019 02:54:26 -0700 X-ExtLoop1: 1 Received: from rjwysock-mobl1.ger.corp.intel.com (HELO [10.249.139.208]) ([10.249.139.208]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jun 2019 02:54:24 -0700 Subject: Re: [patch 1/3] drivers/cpuidle: add cpuidle-haltpoll driver To: Marcelo Tosatti Cc: kvm-devel , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LDhMKNbcODwqHDhcKZ?= , Andrea Arcangeli , Peter Zijlstra , Wanpeng Li , Konrad Rzeszutek Wilk , Raslan KarimAllah , Boris Ostrovsky , Ankur Arora , Christian Borntraeger , Linux PM References: <20190603225242.289109849@amt.cnet> <20190603225254.212931277@amt.cnet> From: "Rafael J. Wysocki" Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego 173, 80-298 Gdansk Message-ID: <15323308-131f-6ae0-16d8-225aa275e89c@intel.com> Date: Fri, 7 Jun 2019 11:54:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190603225254.212931277@amt.cnet> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 6/4/2019 12:52 AM, Marcelo Tosatti wrote: It is rather inconvenient to comment patches posted as attachments. Anyway, IMO adding trace events at this point is premature, please move adding them to a separate patch at the end of the series.