KVM Archive on lore.kernel.org
 help / color / Atom feed
From: no-reply@patchew.org
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, thuth@redhat.com,
	kvm@vger.kernel.org, quintela@redhat.com, dgilbert@redhat.com,
	pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PULL 00/19] Migration patches
Date: Thu, 11 Jul 2019 06:00:14 -0700 (PDT)
Message-ID: <156285001300.9994.16708326541124429284@c4a48874b076> (raw)
In-Reply-To: <20190711104412.31233-1-quintela@redhat.com>

Patchew URL: https://patchew.org/QEMU/20190711104412.31233-1-quintela@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190711104412.31233-1-quintela@redhat.com
Type: series
Subject: [Qemu-devel] [PULL 00/19] Migration patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190711104412.31233-1-quintela@redhat.com -> patchew/20190711104412.31233-1-quintela@redhat.com
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Switched to a new branch 'test'
209c2845db migration: allow private destination ram with x-ignore-shared
c008de3513 migration: Split log_clear() into smaller chunks
1b98b966ec kvm: Support KVM_CLEAR_DIRTY_LOG
6850c34958 kvm: Introduce slots lock for memory listener
787a3e91db kvm: Persistent per kvmslot dirty bitmap
18fb631382 kvm: Update comments for sync_dirty_bitmap
86d95e6ce0 memory: Introduce memory listener hook log_clear()
d1063f1461 memory: Pass mr into snapshot_and_clear_dirty
3fafbda5af bitmap: Add bitmap_copy_with_{src|dst}_offset()
78c643f8c7 memory: Don't set migration bitmap when without migration
c5bac6deb3 migration: No need to take rcu during sync_dirty_bitmap
ea445e2533 migratioin/ram.c: reset complete_round when we gets a queued page
e8e5e91626 migration/multifd: sync packet_num after all thread are done
e5c62ba89d cutils: remove one unnecessary pointer operation
5914c83527 migration/xbzrle: update cache and current_data in one place
404656a2b0 migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS
fd522f622b migration-test: Add migration multifd test
410a42b077 migration-test: rename parameter to parameter_int
c4c921ae43 migration: fix multifd_recv event typo

=== OUTPUT BEGIN ===
1/19 Checking commit c4c921ae438d (migration: fix multifd_recv event typo)
2/19 Checking commit 410a42b0779f (migration-test: rename parameter to parameter_int)
3/19 Checking commit fd522f622bf7 (migration-test: Add migration multifd test)
4/19 Checking commit 404656a2b029 (migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS)
5/19 Checking commit 5914c835270c (migration/xbzrle: update cache and current_data in one place)
6/19 Checking commit e5c62ba89d60 (cutils: remove one unnecessary pointer operation)
7/19 Checking commit e8e5e91626d2 (migration/multifd: sync packet_num after all thread are done)
8/19 Checking commit ea445e253364 (migratioin/ram.c: reset complete_round when we gets a queued page)
9/19 Checking commit c5bac6deb363 (migration: No need to take rcu during sync_dirty_bitmap)
10/19 Checking commit 78c643f8c785 (memory: Don't set migration bitmap when without migration)
11/19 Checking commit 3fafbda5afa5 (bitmap: Add bitmap_copy_with_{src|dst}_offset())
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#67: 
new file mode 100644

total: 0 errors, 1 warnings, 193 lines checked

Patch 11/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/19 Checking commit d1063f1461e2 (memory: Pass mr into snapshot_and_clear_dirty)
13/19 Checking commit 86d95e6ce000 (memory: Introduce memory listener hook log_clear())
14/19 Checking commit 18fb63138295 (kvm: Update comments for sync_dirty_bitmap)
15/19 Checking commit 787a3e91dbe7 (kvm: Persistent per kvmslot dirty bitmap)
16/19 Checking commit 6850c3495802 (kvm: Introduce slots lock for memory listener)
17/19 Checking commit 1b98b966ec31 (kvm: Support KVM_CLEAR_DIRTY_LOG)
WARNING: line over 80 characters
#201: FILE: accel/kvm/kvm-all.c:1054:
+    KVMMemoryListener *kml = container_of(listener, KVMMemoryListener, listener);

total: 0 errors, 1 warnings, 217 lines checked

Patch 17/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/19 Checking commit c008de3513ac (migration: Split log_clear() into smaller chunks)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

ERROR: trailing whitespace
#48: FILE: include/exec/memory.h.rej:6:
+ $

ERROR: trailing whitespace
#670: FILE: memory.c.rej:6:
+ $

ERROR: trailing whitespace
#5765: FILE: migration/ram.c.rej:4:
+ $

ERROR: trailing whitespace
#5772: FILE: migration/ram.c.rej:11:
+ $

total: 4 errors, 1 warnings, 6000 lines checked

Patch 18/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/19 Checking commit 209c2845db95 (migration: allow private destination ram with x-ignore-shared)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190711104412.31233-1-quintela@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply index

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 10:43 Juan Quintela
2019-07-11 10:43 ` [PULL 01/19] migration: fix multifd_recv event typo Juan Quintela
2019-07-11 10:43 ` [PULL 02/19] migration-test: rename parameter to parameter_int Juan Quintela
2019-07-11 10:43 ` [PULL 03/19] migration-test: Add migration multifd test Juan Quintela
2019-07-11 10:43 ` [PULL 04/19] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS Juan Quintela
2019-07-11 10:43 ` [PULL 05/19] migration/xbzrle: update cache and current_data in one place Juan Quintela
2019-07-11 10:43 ` [PULL 06/19] cutils: remove one unnecessary pointer operation Juan Quintela
2019-07-11 10:44 ` [PULL 07/19] migration/multifd: sync packet_num after all thread are done Juan Quintela
2019-07-11 10:44 ` [PULL 08/19] migratioin/ram.c: reset complete_round when we gets a queued page Juan Quintela
2019-07-11 10:44 ` [PULL 09/19] migration: No need to take rcu during sync_dirty_bitmap Juan Quintela
2019-07-11 10:44 ` [PULL 10/19] memory: Don't set migration bitmap when without migration Juan Quintela
2019-07-11 10:44 ` [PULL 11/19] bitmap: Add bitmap_copy_with_{src|dst}_offset() Juan Quintela
2019-07-11 10:44 ` [PULL 12/19] memory: Pass mr into snapshot_and_clear_dirty Juan Quintela
2019-07-11 10:44 ` [PULL 13/19] memory: Introduce memory listener hook log_clear() Juan Quintela
2019-07-11 10:44 ` [PULL 14/19] kvm: Update comments for sync_dirty_bitmap Juan Quintela
2019-07-11 10:44 ` [PULL 15/19] kvm: Persistent per kvmslot dirty bitmap Juan Quintela
2019-07-11 10:44 ` [PULL 16/19] kvm: Introduce slots lock for memory listener Juan Quintela
2019-07-11 10:44 ` [PULL 17/19] kvm: Support KVM_CLEAR_DIRTY_LOG Juan Quintela
2019-07-11 10:44 ` [PULL 19/19] migration: allow private destination ram with x-ignore-shared Juan Quintela
2019-07-11 11:19 ` [PULL 00/19] Migration patches Paolo Bonzini
2019-07-11 11:32   ` Juan Quintela
2019-07-11 11:34   ` Dr. David Alan Gilbert
2019-07-11 11:40     ` [Qemu-devel] " Peter Maydell
2019-07-11 12:39 ` Peter Maydell
2019-07-12 14:06   ` Juan Quintela
2019-07-11 12:55 ` Christian Borntraeger
2019-07-11 13:01   ` [Qemu-devel] " Peter Maydell
2019-07-11 13:00 ` no-reply [this message]
2019-07-12 14:33 ` no-reply
2019-07-12 14:31 Juan Quintela
2019-07-12 16:33 ` [Qemu-devel] " Peter Maydell
2019-07-12 17:54   ` Dr. David Alan Gilbert
2019-07-15 11:16   ` Peter Maydell
2019-07-15 14:04     ` Daniel P. Berrangé
2019-07-15 14:17       ` Peter Maydell

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156285001300.9994.16708326541124429284@c4a48874b076 \
    --to=no-reply@patchew.org \
    --cc=dgilbert@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org kvm@archiver.kernel.org
	public-inbox-index kvm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox